Sbisson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/221272
Change subject: Suppress topic creation entry from RC, watchlist, contributions
......................................................................
Suppress topic creation entry from RC, watchlist, contributions
Bug: T94360
Change-Id: I39369674fcd7373c4c018c734e0e2046adedfa5a
---
M FlowActions.php
M includes/Formatter/ContributionsQuery.php
M includes/Model/PostRevision.php
3 files changed, 15 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/72/221272/1
diff --git a/FlowActions.php b/FlowActions.php
index e9b6d5a..6eaf38e 100644
--- a/FlowActions.php
+++ b/FlowActions.php
@@ -245,8 +245,7 @@
'new-topic' => array(
'performs-writes' => true,
'log_type' => false,
- 'rc_insert' => true,
- 'rc_title' => 'owner',
+ 'rc_insert' => false,
'permissions' => array(
PostRevision::MODERATED_NONE => '',
),
diff --git a/includes/Formatter/ContributionsQuery.php
b/includes/Formatter/ContributionsQuery.php
index bcd6c69..f367d07 100644
--- a/includes/Formatter/ContributionsQuery.php
+++ b/includes/Formatter/ContributionsQuery.php
@@ -10,6 +10,7 @@
use Flow\DbFactory;
use Flow\Data\ManagerGroup;
use Flow\Model\UUID;
+use Flow\Model\PostRevision;
use Flow\Repository\TreeRepository;
use Flow\Exception\FlowException;
use ResultWrapper;
@@ -71,6 +72,12 @@
$this->loadMetadataBatch( $revisions );
foreach ( $revisions as $revision ) {
try {
+ // hide topic creation from user
contribution
+ // also not shown in RC or watchlist
+ if ( $revision instanceof PostRevision
&& $revision->isInitialTopicCreation() ) {
+ continue;
+ }
+
$result = $pager instanceof
ContribsPager ? new ContributionsRow : new DeletedContributionsRow;
$result = $this->buildResult(
$revision, $pager->getIndexField(), $result );
$deleted =
$result->currentRevision->isDeleted() || $result->workflow->isDeleted();
diff --git a/includes/Model/PostRevision.php b/includes/Model/PostRevision.php
index a901844..422df3d 100644
--- a/includes/Model/PostRevision.php
+++ b/includes/Model/PostRevision.php
@@ -386,4 +386,11 @@
public function getCollection() {
return PostCollection::newFromRevision( $this );
}
+
+ /**
+ * @return bool
+ */
+ public function isInitialTopicCreation() {
+ return $this->isTopicTitle() && $this->getChangeType() ===
'new-post';
+ }
}
--
To view, visit https://gerrit.wikimedia.org/r/221272
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39369674fcd7373c4c018c734e0e2046adedfa5a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Sbisson <sbis...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
