[MediaWiki-commits] [Gerrit] Use UNION ALL in EntityUsageTable::getUsedEntityIdStrings - change (mediawiki...Wikibase)
jenkins-bot has submitted this change and it was merged.
Change subject: Use UNION ALL in EntityUsageTable::getUsedEntityIdStrings
..
Use UNION ALL in EntityUsageTable::getUsedEntityIdStrings
Will yield the same results due to the nature of the query.
Bug: T137972
Change-Id: Ia51237668ab8abaaae50525464915e04a58704f9
---
M client/includes/Usage/Sql/EntityUsageTable.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/client/includes/Usage/Sql/EntityUsageTable.php
b/client/includes/Usage/Sql/EntityUsageTable.php
index b70a777..ba1268d 100644
--- a/client/includes/Usage/Sql/EntityUsageTable.php
+++ b/client/includes/Usage/Sql/EntityUsageTable.php
@@ -362,7 +362,7 @@
$values = [];
if ( $this->connection->getType() === 'mysql' ) {
// On MySQL we can UNION all queries and run them at
once
- $sql = $this->connection->unionQueries( $subQueries,
false );
+ $sql = $this->connection->unionQueries( $subQueries,
true );
$res = $this->connection->query( $sql, __METHOD__ );
foreach ( $res as $row ) {
--
To view, visit https://gerrit.wikimedia.org/r/294865
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia51237668ab8abaaae50525464915e04a58704f9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man
Gerrit-Reviewer: Aaron Schulz
Gerrit-Reviewer: Aude
Gerrit-Reviewer: Daniel Kinzler
Gerrit-Reviewer: Hoo man
Gerrit-Reviewer: JanZerebecki
Gerrit-Reviewer: Jcrespo
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use UNION ALL in EntityUsageTable::getUsedEntityIdStrings - change (mediawiki...Wikibase)
Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/294865
Change subject: Use UNION ALL in EntityUsageTable::getUsedEntityIdStrings
..
Use UNION ALL in EntityUsageTable::getUsedEntityIdStrings
Will yield the same results due to the nature of the query.
Bug: T137972
Change-Id: Ia51237668ab8abaaae50525464915e04a58704f9
---
M client/includes/Usage/Sql/EntityUsageTable.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/65/294865/1
diff --git a/client/includes/Usage/Sql/EntityUsageTable.php
b/client/includes/Usage/Sql/EntityUsageTable.php
index b70a777..ba1268d 100644
--- a/client/includes/Usage/Sql/EntityUsageTable.php
+++ b/client/includes/Usage/Sql/EntityUsageTable.php
@@ -362,7 +362,7 @@
$values = [];
if ( $this->connection->getType() === 'mysql' ) {
// On MySQL we can UNION all queries and run them at
once
- $sql = $this->connection->unionQueries( $subQueries,
false );
+ $sql = $this->connection->unionQueries( $subQueries,
true );
$res = $this->connection->query( $sql, __METHOD__ );
foreach ( $res as $row ) {
--
To view, visit https://gerrit.wikimedia.org/r/294865
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia51237668ab8abaaae50525464915e04a58704f9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
