[MediaWiki-commits] [Gerrit] Use cloneWithData in beforePaste - change (VisualEditor/VisualEditor)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Use cloneWithData in beforePaste
..


Use cloneWithData in beforePaste

Change-Id: Ie53ede24c164bcfee58e035ed770714f26d0ead5
---
M src/ce/ve.ce.Surface.js
1 file changed, 1 insertion(+), 5 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index 7fa8411..7e78a99 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -1820,11 +1820,7 @@
// before conversion as it can affect textStart/End offsets.
delete contextElement.internal;
ve.dm.converter.getDomSubtreeFromModel(
-   new ve.dm.Document(
-   new ve.dm.ElementLinearData( 
documentModel.getStore(), context ),
-   documentModel.getHtmlDocument(), undefined, 
documentModel.getInternalList(),
-   documentModel.getLang(), documentModel.getDir()
-   ),
+   documentModel.cloneWithData( context, true ),
this.$pasteTarget[ 0 ]
);
 

-- 
To view, visit https://gerrit.wikimedia.org/r/291787
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie53ede24c164bcfee58e035ed770714f26d0ead5
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Use cloneWithData in beforePaste - change (VisualEditor/VisualEditor)

[Esanders (Code Review)]

Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291787

Change subject: Use cloneWithData in beforePaste
..

Use cloneWithData in beforePaste

Change-Id: Ie53ede24c164bcfee58e035ed770714f26d0ead5
---
M src/ce/ve.ce.Surface.js
1 file changed, 1 insertion(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/87/291787/1

diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index 7fa8411..7e78a99 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -1820,11 +1820,7 @@
// before conversion as it can affect textStart/End offsets.
delete contextElement.internal;
ve.dm.converter.getDomSubtreeFromModel(
-   new ve.dm.Document(
-   new ve.dm.ElementLinearData( 
documentModel.getStore(), context ),
-   documentModel.getHtmlDocument(), undefined, 
documentModel.getInternalList(),
-   documentModel.getLang(), documentModel.getDir()
-   ),
+   documentModel.cloneWithData( context, true ),
this.$pasteTarget[ 0 ]
);
 

-- 
To view, visit https://gerrit.wikimedia.org/r/291787
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie53ede24c164bcfee58e035ed770714f26d0ead5
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits