[MediaWiki-commits] [Gerrit] Use the specified page ID for LinksDeletionUpdate - change (mediawiki/core)
Aaron Schulz has submitted this change and it was merged.
Change subject: Use the specified page ID for LinksDeletionUpdate
..
Use the specified page ID for LinksDeletionUpdate
This makes LinksDeleteJob use the correct page ID when a new
page was later created at the title. The links and protection
rows to clear should always be for the ID of the actual page
being deleted.
This fixes a bug when pages are moved over redirects.
Bug: T128624
Change-Id: Id67a021539b97020e8dd32d56dba1b77c806f31c
---
M includes/deferred/LinksDeletionUpdate.php
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/deferred/LinksDeletionUpdate.php
b/includes/deferred/LinksDeletionUpdate.php
index b8bd747..c227ecd 100644
--- a/includes/deferred/LinksDeletionUpdate.php
+++ b/includes/deferred/LinksDeletionUpdate.php
@@ -37,10 +37,10 @@
parent::__construct( false ); // no implicit transaction
$this->page = $page;
- if ( $page->exists() ) {
+ if ( $pageId ) {
+ $this->pageId = $pageId; // page ID at time of deletion
+ } elseif ( $page->exists() ) {
$this->pageId = $page->getId();
- } elseif ( $pageId ) {
- $this->pageId = $pageId;
} else {
throw new InvalidArgumentException( "Page ID not known.
Page doesn't exist?" );
}
--
To view, visit https://gerrit.wikimedia.org/r/294388
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id67a021539b97020e8dd32d56dba1b77c806f31c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.28.0-wmf.6
Gerrit-Owner: Aaron Schulz
Gerrit-Reviewer: Aaron Schulz
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use the specified page ID for LinksDeletionUpdate - change (mediawiki/core)
jenkins-bot has submitted this change and it was merged.
Change subject: Use the specified page ID for LinksDeletionUpdate
..
Use the specified page ID for LinksDeletionUpdate
This makes LinksDeleteJob use the correct page ID when a new
page was later created at the title. The links and protection
rows to clear should always be for the ID of the actual page
being deleted.
This fixes a bug when pages are moved over redirects.
Bug: T128624
Change-Id: Id67a021539b97020e8dd32d56dba1b77c806f31c
---
M includes/deferred/LinksDeletionUpdate.php
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/deferred/LinksDeletionUpdate.php
b/includes/deferred/LinksDeletionUpdate.php
index b8bd747..c227ecd 100644
--- a/includes/deferred/LinksDeletionUpdate.php
+++ b/includes/deferred/LinksDeletionUpdate.php
@@ -37,10 +37,10 @@
parent::__construct( false ); // no implicit transaction
$this->page = $page;
- if ( $page->exists() ) {
+ if ( $pageId ) {
+ $this->pageId = $pageId; // page ID at time of deletion
+ } elseif ( $page->exists() ) {
$this->pageId = $page->getId();
- } elseif ( $pageId ) {
- $this->pageId = $pageId;
} else {
throw new InvalidArgumentException( "Page ID not known.
Page doesn't exist?" );
}
--
To view, visit https://gerrit.wikimedia.org/r/294387
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id67a021539b97020e8dd32d56dba1b77c806f31c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.28.0-wmf.5
Gerrit-Owner: Aaron Schulz
Gerrit-Reviewer: Aaron Schulz
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use the specified page ID for LinksDeletionUpdate - change (mediawiki/core)
jenkins-bot has submitted this change and it was merged.
Change subject: Use the specified page ID for LinksDeletionUpdate
..
Use the specified page ID for LinksDeletionUpdate
This makes LinksDeleteJob use the correct page ID when a new
page was later created at the title. The links and protection
rows to clear should always be for the ID of the actual page
being deleted.
This fixes a bug when pages are moved over redirects.
Bug: T128624
Change-Id: Id67a021539b97020e8dd32d56dba1b77c806f31c
---
M includes/deferred/LinksDeletionUpdate.php
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Dpatrick: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/deferred/LinksDeletionUpdate.php
b/includes/deferred/LinksDeletionUpdate.php
index b8bd747..c227ecd 100644
--- a/includes/deferred/LinksDeletionUpdate.php
+++ b/includes/deferred/LinksDeletionUpdate.php
@@ -37,10 +37,10 @@
parent::__construct( false ); // no implicit transaction
$this->page = $page;
- if ( $page->exists() ) {
+ if ( $pageId ) {
+ $this->pageId = $pageId; // page ID at time of deletion
+ } elseif ( $page->exists() ) {
$this->pageId = $page->getId();
- } elseif ( $pageId ) {
- $this->pageId = $pageId;
} else {
throw new InvalidArgumentException( "Page ID not known.
Page doesn't exist?" );
}
--
To view, visit https://gerrit.wikimedia.org/r/294034
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id67a021539b97020e8dd32d56dba1b77c806f31c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz
Gerrit-Reviewer: Brian Wolff
Gerrit-Reviewer: Dpatrick
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use the specified page ID for LinksDeletionUpdate - change (mediawiki/core)
Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/294388
Change subject: Use the specified page ID for LinksDeletionUpdate
..
Use the specified page ID for LinksDeletionUpdate
This makes LinksDeleteJob use the correct page ID when a new
page was later created at the title. The links and protection
rows to clear should always be for the ID of the actual page
being deleted.
This fixes a bug when pages are moved over redirects.
Bug: T128624
Change-Id: Id67a021539b97020e8dd32d56dba1b77c806f31c
---
M includes/deferred/LinksDeletionUpdate.php
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/88/294388/1
diff --git a/includes/deferred/LinksDeletionUpdate.php
b/includes/deferred/LinksDeletionUpdate.php
index b8bd747..c227ecd 100644
--- a/includes/deferred/LinksDeletionUpdate.php
+++ b/includes/deferred/LinksDeletionUpdate.php
@@ -37,10 +37,10 @@
parent::__construct( false ); // no implicit transaction
$this->page = $page;
- if ( $page->exists() ) {
+ if ( $pageId ) {
+ $this->pageId = $pageId; // page ID at time of deletion
+ } elseif ( $page->exists() ) {
$this->pageId = $page->getId();
- } elseif ( $pageId ) {
- $this->pageId = $pageId;
} else {
throw new InvalidArgumentException( "Page ID not known.
Page doesn't exist?" );
}
--
To view, visit https://gerrit.wikimedia.org/r/294388
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id67a021539b97020e8dd32d56dba1b77c806f31c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.28.0-wmf.6
Gerrit-Owner: Aaron Schulz
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use the specified page ID for LinksDeletionUpdate - change (mediawiki/core)
Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/294387
Change subject: Use the specified page ID for LinksDeletionUpdate
..
Use the specified page ID for LinksDeletionUpdate
This makes LinksDeleteJob use the correct page ID when a new
page was later created at the title. The links and protection
rows to clear should always be for the ID of the actual page
being deleted.
This fixes a bug when pages are moved over redirects.
Bug: T128624
Change-Id: Id67a021539b97020e8dd32d56dba1b77c806f31c
---
M includes/deferred/LinksDeletionUpdate.php
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/87/294387/1
diff --git a/includes/deferred/LinksDeletionUpdate.php
b/includes/deferred/LinksDeletionUpdate.php
index b8bd747..c227ecd 100644
--- a/includes/deferred/LinksDeletionUpdate.php
+++ b/includes/deferred/LinksDeletionUpdate.php
@@ -37,10 +37,10 @@
parent::__construct( false ); // no implicit transaction
$this->page = $page;
- if ( $page->exists() ) {
+ if ( $pageId ) {
+ $this->pageId = $pageId; // page ID at time of deletion
+ } elseif ( $page->exists() ) {
$this->pageId = $page->getId();
- } elseif ( $pageId ) {
- $this->pageId = $pageId;
} else {
throw new InvalidArgumentException( "Page ID not known.
Page doesn't exist?" );
}
--
To view, visit https://gerrit.wikimedia.org/r/294387
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id67a021539b97020e8dd32d56dba1b77c806f31c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.28.0-wmf.5
Gerrit-Owner: Aaron Schulz
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use the specified page ID for LinksDeletionUpdate - change (mediawiki/core)
Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/294034
Change subject: Use the specified page ID for LinksDeletionUpdate
..
Use the specified page ID for LinksDeletionUpdate
This makes LinksDeleteJob use the correct page ID when a new
page was later created at the title. The links and protection
rows to clear should always be for the ID of the actual page
being deleted.
This fixes a bug when pages are moved over redirects.
Bug: T128624
Change-Id: Id67a021539b97020e8dd32d56dba1b77c806f31c
---
M includes/deferred/LinksDeletionUpdate.php
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/34/294034/1
diff --git a/includes/deferred/LinksDeletionUpdate.php
b/includes/deferred/LinksDeletionUpdate.php
index b8bd747..c227ecd 100644
--- a/includes/deferred/LinksDeletionUpdate.php
+++ b/includes/deferred/LinksDeletionUpdate.php
@@ -37,10 +37,10 @@
parent::__construct( false ); // no implicit transaction
$this->page = $page;
- if ( $page->exists() ) {
+ if ( $pageId ) {
+ $this->pageId = $pageId; // page ID at time of deletion
+ } elseif ( $page->exists() ) {
$this->pageId = $page->getId();
- } elseif ( $pageId ) {
- $this->pageId = $pageId;
} else {
throw new InvalidArgumentException( "Page ID not known.
Page doesn't exist?" );
}
--
To view, visit https://gerrit.wikimedia.org/r/294034
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id67a021539b97020e8dd32d56dba1b77c806f31c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz
Gerrit-Reviewer: Brian Wolff
Gerrit-Reviewer: Dpatrick
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
