[MediaWiki-commits] [Gerrit] Use tox for running flake8 - change (mediawiki...UploadWizard)

2015-03-25 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Use tox for running flake8
..


Use tox for running flake8

Also instead of totally ignoring line length, set a max of 120

The [pep8] section is left in since jenkins is still running pep8, and should
be removed once jenkins is updated to use tox instead.

Change-Id: Id18ae52a5db4d1d7cb112fde895dde94217d38da
---
M .gitignore
M tox.ini
2 files changed, 18 insertions(+), 2 deletions(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/.gitignore b/.gitignore
index 6625c5d..19649be 100644
--- a/.gitignore
+++ b/.gitignore
@@ -7,3 +7,4 @@
 tests/browser/.gem
 tests/browser/.bundle
 node_modules
+.tox
diff --git a/tox.ini b/tox.ini
index 555e4de..d432c1b 100644
--- a/tox.ini
+++ b/tox.ini
@@ -1,6 +1,21 @@
+[tox]
+
+# Ensure 1.6+ is used to support 'skipsdist'
+minversion = 1.6
+
+# Do not run install command
+skipsdist = True
+
+# Environements to execute when invoking 'tox'
+envlist = flake8
+
+[testenv:flake8]
+commands = flake8
+deps = flake8
+
 [flake8]
-; E501 line too long
-ignore = E501
+exclude = .tox
+max_line_length = 120
 
 [pep8]
 ; E501 line too long

-- 
To view, visit https://gerrit.wikimedia.org/r/196744
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id18ae52a5db4d1d7cb112fde895dde94217d38da
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: Gergő Tisza gti...@wikimedia.org
Gerrit-Reviewer: Gilles gdu...@wikimedia.org
Gerrit-Reviewer: Hashar has...@free.fr
Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: MarkTraceur mtrac...@member.fsf.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Use tox for running flake8 - change (mediawiki...UploadWizard)

2015-03-13 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/196744

Change subject: Use tox for running flake8
..

Use tox for running flake8

Also instead of totally ignoring line length, set a max of 120

Change-Id: Id18ae52a5db4d1d7cb112fde895dde94217d38da
---
M .gitignore
M tox.ini
2 files changed, 18 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard 
refs/changes/44/196744/1

diff --git a/.gitignore b/.gitignore
index 6625c5d..19649be 100644
--- a/.gitignore
+++ b/.gitignore
@@ -7,3 +7,4 @@
 tests/browser/.gem
 tests/browser/.bundle
 node_modules
+.tox
diff --git a/tox.ini b/tox.ini
index 555e4de..f05cb65 100644
--- a/tox.ini
+++ b/tox.ini
@@ -1,7 +1,18 @@
-[flake8]
-; E501 line too long
-ignore = E501
+[tox]
 
-[pep8]
-; E501 line too long
-ignore = E501
+# Ensure 1.6+ is used to support 'skipsdist'
+minversion = 1.6
+
+# Do not run install command
+skipsdist = True
+
+# Environements to execute when invoking 'tox'
+envlist = flake8
+
+[testenv:flake8]
+commands = flake8
+deps = flake8
+
+[flake8]
+exclude = .tox
+max_line_length = 120

-- 
To view, visit https://gerrit.wikimedia.org/r/196744
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id18ae52a5db4d1d7cb112fde895dde94217d38da
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Legoktm legoktm.wikipe...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits