[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Surface: reset selection when popping staging
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/379435 ) Change subject: Surface: reset selection when popping staging .. Surface: reset selection when popping staging Bug: T166134 Change-Id: I905a4d5860a3bdf36477fc798a233e166febd63b --- M src/dm/ve.dm.Surface.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Esanders: Looks good to me, approved jenkins-bot: Verified diff --git a/src/dm/ve.dm.Surface.js b/src/dm/ve.dm.Surface.js index f04ce18..053c531 100644 --- a/src/dm/ve.dm.Surface.js +++ b/src/dm/ve.dm.Surface.js @@ -262,7 +262,7 @@ transaction = transactions[ i ].reversed(); reverseTransactions.push( transaction ); } - this.changeInternal( reverseTransactions, undefined, true ); + this.changeInternal( reverseTransactions, staging.selectionBefore, true ); if ( !this.isStaging() ) { this.startHistoryTracking(); -- To view, visit https://gerrit.wikimedia.org/r/379435 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I905a4d5860a3bdf36477fc798a233e166febd63b Gerrit-PatchSet: 1 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: DLynchGerrit-Reviewer: Esanders Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Surface: reset selection when popping staging
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379435 ) Change subject: Surface: reset selection when popping staging .. Surface: reset selection when popping staging Bug: T166134 Change-Id: I905a4d5860a3bdf36477fc798a233e166febd63b --- M src/dm/ve.dm.Surface.js 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor refs/changes/35/379435/1 diff --git a/src/dm/ve.dm.Surface.js b/src/dm/ve.dm.Surface.js index f04ce18..053c531 100644 --- a/src/dm/ve.dm.Surface.js +++ b/src/dm/ve.dm.Surface.js @@ -262,7 +262,7 @@ transaction = transactions[ i ].reversed(); reverseTransactions.push( transaction ); } - this.changeInternal( reverseTransactions, undefined, true ); + this.changeInternal( reverseTransactions, staging.selectionBefore, true ); if ( !this.isStaging() ) { this.startHistoryTracking(); -- To view, visit https://gerrit.wikimedia.org/r/379435 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I905a4d5860a3bdf36477fc798a233e166febd63b Gerrit-PatchSet: 1 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: DLynch___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits