Hashar has submitted this change and it was merged. Change subject: ant: make git macros to always use 'dir' ......................................................................
ant: make git macros to always use 'dir' Under ant, you end up running all <exec> calls in the $builddir directory which is almost never where you want to run the git command. All macros are no requiring a dir attribute to be set, that is safeguard to make sure we are running git in the correct working directory. Also removed a useless echo in the git macrodef. Did not output the arguments but just the git command. Change-Id: I5aad2c4dabcd3e3da8d750cb035ae4c493c759ca --- M jobs/_shared/build.xml 1 file changed, 22 insertions(+), 12 deletions(-) Approvals: Hashar: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/14058 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5aad2c4dabcd3e3da8d750cb035ae4c493c759ca Gerrit-PatchSet: 1 Gerrit-Project: integration/jenkins Gerrit-Branch: master Gerrit-Owner: Hashar <has...@free.fr> Gerrit-Reviewer: Hashar <has...@free.fr> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
