[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update: dim images in dark mode
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/366998 )
Change subject: Update: dim images in dark mode
..
Update: dim images in dark mode
Change-Id: Ic78c5b9a56bc6088e067cf2296b383a8c701f2cb
---
M app/src/main/assets/bundle.js
M app/src/main/assets/preview.js
M www/js/dark.js
3 files changed, 15 insertions(+), 12 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
jenkins-bot: Verified
Mholloway: Looks good to me, but someone else must approve
diff --git a/app/src/main/assets/bundle.js b/app/src/main/assets/bundle.js
index 726c491..b5ddb1f 100644
--- a/app/src/main/assets/bundle.js
+++ b/app/src/main/assets/bundle.js
@@ -134,12 +134,13 @@
var pagelib = require("wikimedia-page-library");
bridge.registerListener( 'toggleDarkMode', function() {
- var theme;
+var theme;
- window.isDarkMode = !window.isDarkMode;
+window.isDarkMode = !window.isDarkMode;
- theme = window.isDarkMode ? pagelib.ThemeTransform.THEME.DARK :
pagelib.ThemeTransform.THEME.DEFAULT;
- pagelib.ThemeTransform.setTheme( document, theme );
+theme = window.isDarkMode ? pagelib.ThemeTransform.THEME.DARK :
pagelib.ThemeTransform.THEME.DEFAULT;
+pagelib.ThemeTransform.setTheme( document, theme );
+pagelib.DimImagesTransform.dim( window, window.isDarkMode );
} );
},{"./bridge":2,"wikimedia-page-library":20}],4:[function(require,module,exports){
var transformer = require('./transformer');
diff --git a/app/src/main/assets/preview.js b/app/src/main/assets/preview.js
index 18f5cb3..69eefa5 100644
--- a/app/src/main/assets/preview.js
+++ b/app/src/main/assets/preview.js
@@ -134,12 +134,13 @@
var pagelib = require("wikimedia-page-library");
bridge.registerListener( 'toggleDarkMode', function() {
- var theme;
+var theme;
- window.isDarkMode = !window.isDarkMode;
+window.isDarkMode = !window.isDarkMode;
- theme = window.isDarkMode ? pagelib.ThemeTransform.THEME.DARK :
pagelib.ThemeTransform.THEME.DEFAULT;
- pagelib.ThemeTransform.setTheme( document, theme );
+theme = window.isDarkMode ? pagelib.ThemeTransform.THEME.DARK :
pagelib.ThemeTransform.THEME.DEFAULT;
+pagelib.ThemeTransform.setTheme( document, theme );
+pagelib.DimImagesTransform.dim( window, window.isDarkMode );
} );
},{"./bridge":2,"wikimedia-page-library":7}],4:[function(require,module,exports){
var bridge = require("./bridge");
diff --git a/www/js/dark.js b/www/js/dark.js
index 6daad80..913ec7b 100644
--- a/www/js/dark.js
+++ b/www/js/dark.js
@@ -2,10 +2,11 @@
var pagelib = require("wikimedia-page-library");
bridge.registerListener( 'toggleDarkMode', function() {
- var theme;
+var theme;
- window.isDarkMode = !window.isDarkMode;
+window.isDarkMode = !window.isDarkMode;
- theme = window.isDarkMode ? pagelib.ThemeTransform.THEME.DARK :
pagelib.ThemeTransform.THEME.DEFAULT;
- pagelib.ThemeTransform.setTheme( document, theme );
+theme = window.isDarkMode ? pagelib.ThemeTransform.THEME.DARK :
pagelib.ThemeTransform.THEME.DEFAULT;
+pagelib.ThemeTransform.setTheme( document, theme );
+pagelib.DimImagesTransform.dim( window, window.isDarkMode );
} );
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/366998
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic78c5b9a56bc6088e067cf2296b383a8c701f2cb
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski
Gerrit-Reviewer: Brion VIBBER
Gerrit-Reviewer: Dbrant
Gerrit-Reviewer: Mholloway
Gerrit-Reviewer: Sniedzielski
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update: dim images in dark mode
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/366998 )
Change subject: Update: dim images in dark mode
..
Update: dim images in dark mode
Change-Id: Ic78c5b9a56bc6088e067cf2296b383a8c701f2cb
---
M app/src/main/assets/bundle.js
M app/src/main/assets/preview.js
M www/js/dark.js
3 files changed, 15 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/98/366998/1
diff --git a/app/src/main/assets/bundle.js b/app/src/main/assets/bundle.js
index 726c491..b5ddb1f 100644
--- a/app/src/main/assets/bundle.js
+++ b/app/src/main/assets/bundle.js
@@ -134,12 +134,13 @@
var pagelib = require("wikimedia-page-library");
bridge.registerListener( 'toggleDarkMode', function() {
- var theme;
+var theme;
- window.isDarkMode = !window.isDarkMode;
+window.isDarkMode = !window.isDarkMode;
- theme = window.isDarkMode ? pagelib.ThemeTransform.THEME.DARK :
pagelib.ThemeTransform.THEME.DEFAULT;
- pagelib.ThemeTransform.setTheme( document, theme );
+theme = window.isDarkMode ? pagelib.ThemeTransform.THEME.DARK :
pagelib.ThemeTransform.THEME.DEFAULT;
+pagelib.ThemeTransform.setTheme( document, theme );
+pagelib.DimImagesTransform.dim( window, window.isDarkMode );
} );
},{"./bridge":2,"wikimedia-page-library":20}],4:[function(require,module,exports){
var transformer = require('./transformer');
diff --git a/app/src/main/assets/preview.js b/app/src/main/assets/preview.js
index 18f5cb3..69eefa5 100644
--- a/app/src/main/assets/preview.js
+++ b/app/src/main/assets/preview.js
@@ -134,12 +134,13 @@
var pagelib = require("wikimedia-page-library");
bridge.registerListener( 'toggleDarkMode', function() {
- var theme;
+var theme;
- window.isDarkMode = !window.isDarkMode;
+window.isDarkMode = !window.isDarkMode;
- theme = window.isDarkMode ? pagelib.ThemeTransform.THEME.DARK :
pagelib.ThemeTransform.THEME.DEFAULT;
- pagelib.ThemeTransform.setTheme( document, theme );
+theme = window.isDarkMode ? pagelib.ThemeTransform.THEME.DARK :
pagelib.ThemeTransform.THEME.DEFAULT;
+pagelib.ThemeTransform.setTheme( document, theme );
+pagelib.DimImagesTransform.dim( window, window.isDarkMode );
} );
},{"./bridge":2,"wikimedia-page-library":7}],4:[function(require,module,exports){
var bridge = require("./bridge");
diff --git a/www/js/dark.js b/www/js/dark.js
index 6daad80..913ec7b 100644
--- a/www/js/dark.js
+++ b/www/js/dark.js
@@ -2,10 +2,11 @@
var pagelib = require("wikimedia-page-library");
bridge.registerListener( 'toggleDarkMode', function() {
- var theme;
+var theme;
- window.isDarkMode = !window.isDarkMode;
+window.isDarkMode = !window.isDarkMode;
- theme = window.isDarkMode ? pagelib.ThemeTransform.THEME.DARK :
pagelib.ThemeTransform.THEME.DEFAULT;
- pagelib.ThemeTransform.setTheme( document, theme );
+theme = window.isDarkMode ? pagelib.ThemeTransform.THEME.DARK :
pagelib.ThemeTransform.THEME.DEFAULT;
+pagelib.ThemeTransform.setTheme( document, theme );
+pagelib.DimImagesTransform.dim( window, window.isDarkMode );
} );
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/366998
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic78c5b9a56bc6088e067cf2296b383a8c701f2cb
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski
Gerrit-Reviewer: Sniedzielski
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
