[MediaWiki-commits] [Gerrit] dynamicproxy: Followup to I7c13506b1a38f03815481651fd13411f7... - change (operations/puppet)

2016-05-30 Thread Yuvipanda (Code Review) 
Yuvipanda has submitted this change and it was merged.

Change subject: dynamicproxy: Followup to 
I7c13506b1a38f03815481651fd13411f7cf7c0c9
..


dynamicproxy: Followup to I7c13506b1a38f03815481651fd13411f7cf7c0c9

Since the uwsgi::app defines the service to be running anyway.
This is not necessary, and adding it makes puppet barf.

Change-Id: Iedba15ea406102cbb5ff5ca8f5d9cc261804a642
---
M modules/dynamicproxy/manifests/api.pp
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Yuvipanda: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/dynamicproxy/manifests/api.pp 
b/modules/dynamicproxy/manifests/api.pp
index 11579e5..e049db4 100644
--- a/modules/dynamicproxy/manifests/api.pp
+++ b/modules/dynamicproxy/manifests/api.pp
@@ -31,10 +31,6 @@
 subscribe => File['/usr/local/bin/invisible-unicorn.py'],
 }
 
-service { 'uwsgi-invisible-unicorn':
-ensure  => running,
-}
-
 file { '/etc/dynamicproxy-api':
 ensure => directory,
 owner  => 'www-data',

-- 
To view, visit https://gerrit.wikimedia.org/r/291853
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iedba15ea406102cbb5ff5ca8f5d9cc261804a642
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yuvipanda 
Gerrit-Reviewer: Yuvipanda 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] dynamicproxy: Followup to I7c13506b1a38f03815481651fd13411f7... - change (operations/puppet)

2016-05-30 Thread Yuvipanda (Code Review) 
Yuvipanda has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291853

Change subject: dynamicproxy: Followup to 
I7c13506b1a38f03815481651fd13411f7cf7c0c9
..

dynamicproxy: Followup to I7c13506b1a38f03815481651fd13411f7cf7c0c9

Since the uwsgi::app defines the service to be running anyway.
This is not necessary, and adding it makes puppet barf.

Change-Id: Iedba15ea406102cbb5ff5ca8f5d9cc261804a642
---
M modules/dynamicproxy/manifests/api.pp
1 file changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/53/291853/1

diff --git a/modules/dynamicproxy/manifests/api.pp 
b/modules/dynamicproxy/manifests/api.pp
index 11579e5..e049db4 100644
--- a/modules/dynamicproxy/manifests/api.pp
+++ b/modules/dynamicproxy/manifests/api.pp
@@ -31,10 +31,6 @@
 subscribe => File['/usr/local/bin/invisible-unicorn.py'],
 }
 
-service { 'uwsgi-invisible-unicorn':
-ensure  => running,
-}
-
 file { '/etc/dynamicproxy-api':
 ensure => directory,
 owner  => 'www-data',

-- 
To view, visit https://gerrit.wikimedia.org/r/291853
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iedba15ea406102cbb5ff5ca8f5d9cc261804a642
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yuvipanda 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits