[MediaWiki-commits] [Gerrit] integration/docroot[master]: cover: Convert coverage sub-nav from breadcrumbs to nav-tabs
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/405995 )
Change subject: cover: Convert coverage sub-nav from breadcrumbs to nav-tabs
..
cover: Convert coverage sub-nav from breadcrumbs to nav-tabs
Breadcrumbs are mainly intended as a way to go from a subpage back
to an ancestor. Not as a way of going to a subpage.
Given the similarity, it looks somewhat confusing to see the breadcrumbs
visually end with 'MediaWiki extensions' when the user isn't actually
on that page.
Nav-tabs seems like a more appropiate fit within the building blocks
that Bootstrap provides.
Change-Id: Ic7b0cf9d76ed79f12074adf07d054e1fd2456746
---
M shared/CoveragePage.php
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/shared/CoveragePage.php b/shared/CoveragePage.php
index 5314f43..81583ec 100644
--- a/shared/CoveragePage.php
+++ b/shared/CoveragePage.php
@@ -52,18 +52,18 @@
if ( $this->pageName === 'Test coverage' ) {
$href = $this->fixNavUrl( '/cover-extensions/' );
$breadcrumbs = <<
- Coverage home
+
+ Coverage home
MediaWiki extensions
-
+
HTML;
} else {
$href = $this->fixNavUrl( '/cover/' );
$breadcrumbs = <<
+
Coverage home
- MediaWiki extensions
-
+ MediaWiki extensions
+
HTML;
}
$this->addHtmlContent( $breadcrumbs );
--
To view, visit https://gerrit.wikimedia.org/r/405995
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7b0cf9d76ed79f12074adf07d054e1fd2456746
Gerrit-PatchSet: 3
Gerrit-Project: integration/docroot
Gerrit-Branch: master
Gerrit-Owner: Krinkle
Gerrit-Reviewer: Hashar
Gerrit-Reviewer: Krinkle
Gerrit-Reviewer: Legoktm
Gerrit-Reviewer: Paladox
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] integration/docroot[master]: cover: Convert coverage sub-nav from breadcrumbs to nav-tabs
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405995 )
Change subject: cover: Convert coverage sub-nav from breadcrumbs to nav-tabs
..
cover: Convert coverage sub-nav from breadcrumbs to nav-tabs
Breadcrumbs are mainly intended as a way to go from a subpage back
to an ancestor. Not as a way of going to a subpage.
Given the similarity, it looks somewhat confusing to see the breadcrumbs
visually end with 'MediaWiki extensions' when the user isn't actually
on that page.
Nav-tabs seems like a more appropiate fit within the building blocks
that Bootstrap provides.
Change-Id: Ic7b0cf9d76ed79f12074adf07d054e1fd2456746
---
M shared/CoveragePage.php
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/integration/docroot
refs/changes/95/405995/1
diff --git a/shared/CoveragePage.php b/shared/CoveragePage.php
index 8bb60e5..9418a7e 100644
--- a/shared/CoveragePage.php
+++ b/shared/CoveragePage.php
@@ -50,18 +50,18 @@
if ( $this->pageName === 'Test coverage' ) {
$href = $this->fixNavUrl( '/cover-extensions/' );
$breadcrumbs = <<
- Coverage home
+
+ Coverage home
MediaWiki extensions
-
+
HTML;
} else {
$href = $this->fixNavUrl( '/cover/' );
$breadcrumbs = <<
+
Coverage home
- MediaWiki extensions
-
+ MediaWiki extensions
+
HTML;
}
$this->addHtmlContent( $breadcrumbs );
--
To view, visit https://gerrit.wikimedia.org/r/405995
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7b0cf9d76ed79f12074adf07d054e1fd2456746
Gerrit-PatchSet: 1
Gerrit-Project: integration/docroot
Gerrit-Branch: master
Gerrit-Owner: Krinkle
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
