Prtksxna has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/332220 )
Change subject: GallerySlideshow: Don't open MultimediaViewer when a thumbnail
is clicked
......................................................................
GallerySlideshow: Don't open MultimediaViewer when a thumbnail is clicked
Bug: T140595
Change-Id: Ie18a9049eee552cb4519c5608a642044119f677c
---
M resources/src/mediawiki/page/gallery-slideshow.js
1 file changed, 7 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/20/332220/1
diff --git a/resources/src/mediawiki/page/gallery-slideshow.js
b/resources/src/mediawiki/page/gallery-slideshow.js
index e651c9c..7647393 100644
--- a/resources/src/mediawiki/page/gallery-slideshow.js
+++ b/resources/src/mediawiki/page/gallery-slideshow.js
@@ -39,10 +39,13 @@
);
// Disable thumbnails' link, instead show the image in the
carousel
- this.$galleryBox.on( 'click', function ( e ) {
- this.$currentImage = $( e.currentTarget );
- this.showCurrentImage();
- return false;
+ this.$galleryBox // We want the entire list item to be clickable
+ .add( '.gallerybox a' ) // Specific selector so that
MMV doesn't open
+ .on( 'click', function ( e ) {
+ this.$currentImage = $( e.currentTarget
).closest( '.gallerybox' );
+ this.showCurrentImage();
+ e.stopImmediatePropagation(); // Don't let MMV
open
+ return false;
}.bind( this ) );
};
--
To view, visit https://gerrit.wikimedia.org/r/332220
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie18a9049eee552cb4519c5608a642044119f677c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <psax...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
