jenkins-bot has submitted this change and it was merged. Change subject: mediawiki.requestIdleCallback: Avoid native window.requestIdleCallback ......................................................................
mediawiki.requestIdleCallback: Avoid native window.requestIdleCallback Follows-up 482ad8d9fb. This currently has bugs in Chrome that can cause it to not get called for up to 30 seconds. https://bugs.chromium.org/p/chromium/issues/detail?id=647870 Change-Id: I221cd6c2bcdbee89bc7401c071f2ab1865a738ed --- M resources/src/mediawiki/mediawiki.requestIdleCallback.js M tests/qunit/suites/resources/mediawiki/mediawiki.requestIdleCallback.test.js 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/src/mediawiki/mediawiki.requestIdleCallback.js b/resources/src/mediawiki/mediawiki.requestIdleCallback.js index dfc98ad..b58cb69 100644 --- a/resources/src/mediawiki/mediawiki.requestIdleCallback.js +++ b/resources/src/mediawiki/mediawiki.requestIdleCallback.js @@ -24,8 +24,12 @@ * @member mw * @param {Function} callback */ + mw.requestIdleCallback = mw.requestIdleCallbackInternal; + /* + // XXX: Polyfill disabled due to https://bugs.chromium.org/p/chromium/issues/detail?id=647870 mw.requestIdleCallback = window.requestIdleCallback // Bind because it throws TypeError if context is not window ? window.requestIdleCallback.bind( window ) : mw.requestIdleCallbackInternal; + */ }( mediaWiki ) ); diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.requestIdleCallback.test.js b/tests/qunit/suites/resources/mediawiki/mediawiki.requestIdleCallback.test.js index 7a09964..df02693 100644 --- a/tests/qunit/suites/resources/mediawiki/mediawiki.requestIdleCallback.test.js +++ b/tests/qunit/suites/resources/mediawiki/mediawiki.requestIdleCallback.test.js @@ -95,8 +95,9 @@ if ( window.requestIdleCallback ) { QUnit.test( 'native', function ( assert ) { var done = assert.async(); - // Remove polyfill + // Remove polyfill and clock stub mw.requestIdleCallback.restore(); + this.clock.restore(); mw.requestIdleCallback( function () { assert.expect( 0 ); done(); -- To view, visit https://gerrit.wikimedia.org/r/311861 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I221cd6c2bcdbee89bc7401c071f2ab1865a738ed Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org> Gerrit-Reviewer: Catrope <roan.katt...@gmail.com> Gerrit-Reviewer: Gilles <gdu...@wikimedia.org> Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net> Gerrit-Reviewer: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
