[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [propose] RCFilters: Use the base default for 'rclimit'

[Mooeypoo (Code Review)]

Mooeypoo has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368949 )

Change subject: [propose] RCFilters: Use the base default for 'rclimit'
......................................................................

[propose] RCFilters: Use the base default for 'rclimit'

Bug: T172156
Bug: T171202
Change-Id: Iea14bec6399bd84c40aeda5e6e180a1882949c1c
---
M resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
1 file changed, 4 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/49/368949/1

diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js 
b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
index 4051eda..109e5cb 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
@@ -88,11 +88,6 @@
                        };
                }
 
-               // Convert the default from the old preference
-               // since the limit preference actually affects more
-               // than just the RecentChanges page
-               limitDefault = Number( mw.user.options.get( 
'rcfilters-rclimit', mw.user.options.get( 'rclimit', '50' ) ) );
-
                // Add parameter range operations
                views.range = {
                        groups: [
@@ -104,7 +99,7 @@
                                        allowArbitrary: true,
                                        validate: $.isNumeric,
                                        sortFunc: function ( a, b ) { return 
Number( a.name ) - Number( b.name ); },
-                                       'default': String( limitDefault ),
+                                       'default': String( mw.user.options.get( 
'rclimit', '50' ) ),
                                        isSticky: true,
                                        filters: [ 50, 100, 250, 500 ].map( 
function ( num ) {
                                                return 
controller._createFilterDataFromNumber( num, num );
@@ -819,11 +814,11 @@
 
                newValue = Number( newValue );
 
-               if ( mw.user.options.get( 'rcfilters-rclimit' ) !== newValue ) {
+               if ( mw.user.options.get( 'rclimit' ) !== newValue ) {
                        // Save the preference
-                       new mw.Api().saveOption( 'rcfilters-rclimit', newValue 
);
+                       new mw.Api().saveOption( 'rclimit', newValue );
                        // Update the preference for this session
-                       mw.user.options.set( 'rcfilters-rclimit', newValue );
+                       mw.user.options.set( 'rclimit', newValue );
                }
        };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/368949
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea14bec6399bd84c40aeda5e6e180a1882949c1c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits