[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add abstract functions to abstract class..

2018-01-20 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/394643 )

Change subject: Add abstract functions to abstract class..
..


Add abstract functions to abstract class..

Rather than just expecting the child class to have them

Change-Id: Ib145d333e3b8908a8535e974ec8f1f69b2b10e3a
---
M tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Umherirrender: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php 
b/tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php
index 04b12e6..8b8ba0c 100644
--- 
a/tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php
+++ 
b/tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php
@@ -47,6 +47,8 @@
$this->changesListSpecialPage->registerFilters();
}
 
+   abstract protected function getPage();
+
protected function tearDown() {
global $wgGroupPermissions;
 
@@ -57,6 +59,8 @@
}
}
 
+   abstract public function provideParseParameters();
+
/**
 * @dataProvider provideParseParameters
 */

-- 
To view, visit https://gerrit.wikimedia.org/r/394643
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib145d333e3b8908a8535e974ec8f1f69b2b10e3a
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add abstract functions to abstract class..

2017-12-01 Thread Reedy (Code Review) 
Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394643 )

Change subject: Add abstract functions to abstract class..
..

Add abstract functions to abstract class..

Rather than just expecting the child class to have them

Change-Id: Ib145d333e3b8908a8535e974ec8f1f69b2b10e3a
---
M tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/43/394643/1

diff --git 
a/tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php 
b/tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php
index 04b12e6..e0b7818 100644
--- 
a/tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php
+++ 
b/tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php
@@ -47,6 +47,8 @@
$this->changesListSpecialPage->registerFilters();
}
 
+   protected abstract function getPage();
+
protected function tearDown() {
global $wgGroupPermissions;
 
@@ -57,6 +59,8 @@
}
}
 
+   public abstract function provideParseParameters();
+
/**
 * @dataProvider provideParseParameters
 */

-- 
To view, visit https://gerrit.wikimedia.org/r/394643
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib145d333e3b8908a8535e974ec8f1f69b2b10e3a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits