[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Call parent::__construct() in MysqlBase AFTER transferring s...

2016-10-12 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Call parent::__construct() in MysqlBase AFTER transferring 
specific parameters
..


Call parent::__construct() in MysqlBase AFTER transferring specific parameters

Bug: T147852
Change-Id: Id07bb38efb6a9a3b4f4f7e07c0a2c6a74bb1b58d
---
M includes/libs/rdbms/database/DatabaseMysqlBase.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified
  Huji: Looks good to me, but someone else must approve



diff --git a/includes/libs/rdbms/database/DatabaseMysqlBase.php 
b/includes/libs/rdbms/database/DatabaseMysqlBase.php
index f504ec4..e55680a 100644
--- a/includes/libs/rdbms/database/DatabaseMysqlBase.php
+++ b/includes/libs/rdbms/database/DatabaseMysqlBase.php
@@ -72,8 +72,6 @@
 * @param array $params
 */
function __construct( array $params ) {
-   parent::__construct( $params );
-
$this->lagDetectionMethod = isset( 
$params['lagDetectionMethod'] )
? $params['lagDetectionMethod']
: 'Seconds_Behind_Master';
@@ -89,6 +87,8 @@
}
$this->sqlMode = isset( $params['sqlMode'] ) ? 
$params['sqlMode'] : '';
$this->utf8Mode = !empty( $params['utf8Mode'] );
+
+   parent::__construct( $params );
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/315423
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id07bb38efb6a9a3b4f4f7e07c0a2c6a74bb1b58d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: Huji 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Call parent::__construct() in MysqlBase AFTER transferring s...

2016-10-11 Thread Reedy (Code Review) 
Reedy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/315423

Change subject: Call parent::__construct() in MysqlBase AFTER transferring 
specific parameters
..

Call parent::__construct() in MysqlBase AFTER transferring specific parameters

Bug: T147852
Change-Id: Id07bb38efb6a9a3b4f4f7e07c0a2c6a74bb1b58d
---
M includes/libs/rdbms/database/DatabaseMysqlBase.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/23/315423/1

diff --git a/includes/libs/rdbms/database/DatabaseMysqlBase.php 
b/includes/libs/rdbms/database/DatabaseMysqlBase.php
index f504ec4..e55680a 100644
--- a/includes/libs/rdbms/database/DatabaseMysqlBase.php
+++ b/includes/libs/rdbms/database/DatabaseMysqlBase.php
@@ -72,8 +72,6 @@
 * @param array $params
 */
function __construct( array $params ) {
-   parent::__construct( $params );
-
$this->lagDetectionMethod = isset( 
$params['lagDetectionMethod'] )
? $params['lagDetectionMethod']
: 'Seconds_Behind_Master';
@@ -89,6 +87,8 @@
}
$this->sqlMode = isset( $params['sqlMode'] ) ? 
$params['sqlMode'] : '';
$this->utf8Mode = !empty( $params['utf8Mode'] );
+
+   parent::__construct( $params );
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/315423
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id07bb38efb6a9a3b4f4f7e07c0a2c6a74bb1b58d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits