jenkins-bot has submitted this change and it was merged. Change subject: Fix LoadBalancerSingle::reallyOpenConnection() signature ......................................................................
Fix LoadBalancerSingle::reallyOpenConnection() signature Declaration of LoadBalancerSingle::reallyOpenConnection() should be compatible with LoadBalancer::reallyOpenConnection(array $server, $dbNameOverride = false) Caught in https://travis-ci.org/paladox/mediawiki/jobs/167910508 Change-Id: I9bc30249c3b43c3dd3b4eb6f3a70765ef428fd2c --- M includes/libs/rdbms/loadbalancer/LoadBalancerSingle.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Reedy: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/libs/rdbms/loadbalancer/LoadBalancerSingle.php b/includes/libs/rdbms/loadbalancer/LoadBalancerSingle.php index 9de4850..0dec95f 100644 --- a/includes/libs/rdbms/loadbalancer/LoadBalancerSingle.php +++ b/includes/libs/rdbms/loadbalancer/LoadBalancerSingle.php @@ -75,7 +75,7 @@ * * @return IDatabase */ - protected function reallyOpenConnection( $server, $dbNameOverride = false ) { + protected function reallyOpenConnection( array $server, $dbNameOverride = false ) { return $this->db; } } -- To view, visit https://gerrit.wikimedia.org/r/316075 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bc30249c3b43c3dd3b4eb6f3a70765ef428fd2c Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Paladox <thomasmulhall...@yahoo.com> Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org> Gerrit-Reviewer: Anomie <bjor...@wikimedia.org> Gerrit-Reviewer: Chad <ch...@wikimedia.org> Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com> Gerrit-Reviewer: Gergő Tisza <gti...@wikimedia.org> Gerrit-Reviewer: Hashar <has...@free.fr> Gerrit-Reviewer: JanZerebecki <jan.wikime...@zerebecki.de> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org> Gerrit-Reviewer: Paladox <thomasmulhall...@yahoo.com> Gerrit-Reviewer: Reedy <re...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
