[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix 'logName' parameter (5th) in many uses of mw.log.deprecate
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/370960 )
Change subject: Fix 'logName' parameter (5th) in many uses of mw.log.deprecate
..
Fix 'logName' parameter (5th) in many uses of mw.log.deprecate
It's apparently supposed to contains the full name of the deprecated
property/function and apparently almost no one ever remembers it.
This fixes error messages like "Use of "wikiGetlink" is deprecated"
to instead read "Use of "mw.util.wikiGetlink" is deprecated", and
apparently improves some error logging detais.
Change-Id: I9b0d6761754e5844d51b71535e0547205eb20781
---
M resources/src/jquery/jquery.mwExtension.js
M resources/src/mediawiki.legacy/wikibits.js
M resources/src/mediawiki.toolbar/toolbar.js
M resources/src/mediawiki/mediawiki.util.js
4 files changed, 8 insertions(+), 8 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
Jforrester: Looks good to me, but someone else must approve
diff --git a/resources/src/jquery/jquery.mwExtension.js
b/resources/src/jquery/jquery.mwExtension.js
index 4bcccdd..9d970ed 100644
--- a/resources/src/jquery/jquery.mwExtension.js
+++ b/resources/src/jquery/jquery.mwExtension.js
@@ -118,11 +118,11 @@
return true;
}
}, function ( key, value ) {
- mw.log.deprecate( $, key, value );
+ mw.log.deprecate( $, key, value, null, '$.' + key );
} );
mw.log.deprecate( $, 'escapeRE', function ( str ) {
return str.replace( /([\\{}()|.?*+\-^$\[\]])/g, '\\$1' ); //
eslint-disable-line no-useless-escape
- }, 'Use mediawiki.RegExp instead.' );
+ }, 'Use mediawiki.RegExp instead.', '$.escapeRE' );
}( jQuery, mediaWiki ) );
diff --git a/resources/src/mediawiki.legacy/wikibits.js
b/resources/src/mediawiki.legacy/wikibits.js
index 6eccc05..bd1b918 100644
--- a/resources/src/mediawiki.legacy/wikibits.js
+++ b/resources/src/mediawiki.legacy/wikibits.js
@@ -99,7 +99,7 @@
$.each( [ 'write', 'writeln' ], function ( idx, method ) {
mw.log.deprecate( document, method, function () {
$( 'body' ).append( $.parseHTML(
Array.prototype.join.call( arguments, '' ) ) );
- }, 'Use jQuery or mw.loader.load instead.' );
+ }, 'Use jQuery or mw.loader.load instead.', 'document.' +
method );
} );
}( mediaWiki, jQuery ) );
diff --git a/resources/src/mediawiki.toolbar/toolbar.js
b/resources/src/mediawiki.toolbar/toolbar.js
index 9ee499c..d55ed80 100644
--- a/resources/src/mediawiki.toolbar/toolbar.js
+++ b/resources/src/mediawiki.toolbar/toolbar.js
@@ -168,7 +168,7 @@
// Expose API publicly
// @deprecated since MW 1.29
- mw.log.deprecate( mw, 'toolbar', toolbar );
+ mw.log.deprecate( mw, 'toolbar', toolbar, null, 'mw.toolbar' );
$( function () {
var i, button;
diff --git a/resources/src/mediawiki/mediawiki.util.js
b/resources/src/mediawiki/mediawiki.util.js
index 0e423be..34f7eba 100644
--- a/resources/src/mediawiki/mediawiki.util.js
+++ b/resources/src/mediawiki/mediawiki.util.js
@@ -550,7 +550,7 @@
* @inheritdoc #getUrl
* @deprecated since 1.23 Use #getUrl instead.
*/
- mw.log.deprecate( util, 'wikiGetlink', util.getUrl, 'Use mw.util.getUrl
instead.' );
+ mw.log.deprecate( util, 'wikiGetlink', util.getUrl, 'Use mw.util.getUrl
instead.', 'mw.util.wikiGetlink' );
/**
* Add the appropriate prefix to the accesskey shown in the tooltip.
@@ -570,7 +570,7 @@
}
$nodes.updateTooltipAccessKeys();
- }, 'Use jquery.accessKeyLabel instead.' );
+ }, 'Use jquery.accessKeyLabel instead.',
'mw.util.updateTooltipAccessKeys' );
/**
* Add a little box at the top of the screen to inform the user of
@@ -591,7 +591,7 @@
}
mw.notify( message, { autoHide: true, tag: 'legacy' } );
return true;
- }, 'Use mw.notify instead.' );
+ }, 'Use mw.notify instead.', 'mw.util.jsMessage' );
/**
* Encode the string like Sanitizer::escapeId() in PHP
@@ -603,7 +603,7 @@
*/
mw.log.deprecate( util, 'escapeId', function ( str ) {
return escapeIdInternal( str, 'legacy' );
- }, 'Use mw.util.escapeIdForAttribute or mw.util.escapeIdForLink
instead.' );
+ }, 'Use mw.util.escapeIdForAttribute or mw.util.escapeIdForLink
instead.', 'mw.util.escapeId' );
/**
* Initialisation of mw.util.$content
--
To view, visit https://gerrit.wikimedia.org/r/370960
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b0d6761754e5844d51b71535e0547205eb20781
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix 'logName' parameter (5th) in many uses of mw.log.deprecate
Bartosz Dziewoński has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370960 )
Change subject: Fix 'logName' parameter (5th) in many uses of mw.log.deprecate
..
Fix 'logName' parameter (5th) in many uses of mw.log.deprecate
It's apparently supposed to contains the full name of the deprecated
property/function and apparently almost no one ever remembers it.
This fixes error messages like "Use of "wikiGetlink" is deprecated"
to instead read "Use of "mw.util.wikiGetlink" is deprecated", and
apparently improves some error logging detais.
Change-Id: I9b0d6761754e5844d51b71535e0547205eb20781
---
M resources/src/jquery/jquery.mwExtension.js
M resources/src/mediawiki.legacy/wikibits.js
M resources/src/mediawiki.toolbar/toolbar.js
M resources/src/mediawiki/mediawiki.util.js
4 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/60/370960/1
diff --git a/resources/src/jquery/jquery.mwExtension.js
b/resources/src/jquery/jquery.mwExtension.js
index 4bcccdd..9d970ed 100644
--- a/resources/src/jquery/jquery.mwExtension.js
+++ b/resources/src/jquery/jquery.mwExtension.js
@@ -118,11 +118,11 @@
return true;
}
}, function ( key, value ) {
- mw.log.deprecate( $, key, value );
+ mw.log.deprecate( $, key, value, null, '$.' + key );
} );
mw.log.deprecate( $, 'escapeRE', function ( str ) {
return str.replace( /([\\{}()|.?*+\-^$\[\]])/g, '\\$1' ); //
eslint-disable-line no-useless-escape
- }, 'Use mediawiki.RegExp instead.' );
+ }, 'Use mediawiki.RegExp instead.', '$.escapeRE' );
}( jQuery, mediaWiki ) );
diff --git a/resources/src/mediawiki.legacy/wikibits.js
b/resources/src/mediawiki.legacy/wikibits.js
index 6eccc05..bd1b918 100644
--- a/resources/src/mediawiki.legacy/wikibits.js
+++ b/resources/src/mediawiki.legacy/wikibits.js
@@ -99,7 +99,7 @@
$.each( [ 'write', 'writeln' ], function ( idx, method ) {
mw.log.deprecate( document, method, function () {
$( 'body' ).append( $.parseHTML(
Array.prototype.join.call( arguments, '' ) ) );
- }, 'Use jQuery or mw.loader.load instead.' );
+ }, 'Use jQuery or mw.loader.load instead.', 'document.' +
method );
} );
}( mediaWiki, jQuery ) );
diff --git a/resources/src/mediawiki.toolbar/toolbar.js
b/resources/src/mediawiki.toolbar/toolbar.js
index 9ee499c..d55ed80 100644
--- a/resources/src/mediawiki.toolbar/toolbar.js
+++ b/resources/src/mediawiki.toolbar/toolbar.js
@@ -168,7 +168,7 @@
// Expose API publicly
// @deprecated since MW 1.29
- mw.log.deprecate( mw, 'toolbar', toolbar );
+ mw.log.deprecate( mw, 'toolbar', toolbar, null, 'mw.toolbar' );
$( function () {
var i, button;
diff --git a/resources/src/mediawiki/mediawiki.util.js
b/resources/src/mediawiki/mediawiki.util.js
index 0e423be..34f7eba 100644
--- a/resources/src/mediawiki/mediawiki.util.js
+++ b/resources/src/mediawiki/mediawiki.util.js
@@ -550,7 +550,7 @@
* @inheritdoc #getUrl
* @deprecated since 1.23 Use #getUrl instead.
*/
- mw.log.deprecate( util, 'wikiGetlink', util.getUrl, 'Use mw.util.getUrl
instead.' );
+ mw.log.deprecate( util, 'wikiGetlink', util.getUrl, 'Use mw.util.getUrl
instead.', 'mw.util.wikiGetlink' );
/**
* Add the appropriate prefix to the accesskey shown in the tooltip.
@@ -570,7 +570,7 @@
}
$nodes.updateTooltipAccessKeys();
- }, 'Use jquery.accessKeyLabel instead.' );
+ }, 'Use jquery.accessKeyLabel instead.',
'mw.util.updateTooltipAccessKeys' );
/**
* Add a little box at the top of the screen to inform the user of
@@ -591,7 +591,7 @@
}
mw.notify( message, { autoHide: true, tag: 'legacy' } );
return true;
- }, 'Use mw.notify instead.' );
+ }, 'Use mw.notify instead.', 'mw.util.jsMessage' );
/**
* Encode the string like Sanitizer::escapeId() in PHP
@@ -603,7 +603,7 @@
*/
mw.log.deprecate( util, 'escapeId', function ( str ) {
return escapeIdInternal( str, 'legacy' );
- }, 'Use mw.util.escapeIdForAttribute or mw.util.escapeIdForLink
instead.' );
+ }, 'Use mw.util.escapeIdForAttribute or mw.util.escapeIdForLink
instead.', 'mw.util.escapeId' );
/**
* Initialisation of mw.util.$content
--
To view, visit https://gerrit.wikimedia.org/r/370960
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b0d6761754e5844d51b71535e0547205eb20781
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński
