[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix type hints for parameter documentation

2017-08-05 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370226 )

Change subject: Fix type hints for parameter documentation
..


Fix type hints for parameter documentation

Fix double space

Change-Id: Ied34a05b2043a3354ff0629d8bb47a1176d8a74e
---
M includes/installer/DatabaseUpdater.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Umherirrender: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/installer/DatabaseUpdater.php 
b/includes/installer/DatabaseUpdater.php
index 7b6ac5e..8f5858b 100644
--- a/includes/installer/DatabaseUpdater.php
+++ b/includes/installer/DatabaseUpdater.php
@@ -940,10 +940,10 @@
 *
 * @param string $table Name of the table to modify
 * @param string $patch Name of the patch file to apply
-* @param string $fullpath Whether to treat $patch path as relative or 
not, defaults to false
+* @param string|bool $fullpath Whether to treat $patch path as 
relative or not, defaults to false
 * @return bool False if this was skipped because of schema changes 
being skipped
 */
-   public function modifyTable( $table, $patch,  $fullpath = false ) {
+   public function modifyTable( $table, $patch, $fullpath = false ) {
if ( !$this->doTable( $table ) ) {
return true;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/370226
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ied34a05b2043a3354ff0629d8bb47a1176d8a74e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix type hints for parameter documentation

2017-08-04 Thread Reedy (Code Review) 
Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370226 )

Change subject: Fix type hints for parameter documentation
..

Fix type hints for parameter documentation

Fix double space

Change-Id: Ied34a05b2043a3354ff0629d8bb47a1176d8a74e
---
M includes/installer/DatabaseUpdater.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/26/370226/1

diff --git a/includes/installer/DatabaseUpdater.php 
b/includes/installer/DatabaseUpdater.php
index 7b6ac5e..8f5858b 100644
--- a/includes/installer/DatabaseUpdater.php
+++ b/includes/installer/DatabaseUpdater.php
@@ -940,10 +940,10 @@
 *
 * @param string $table Name of the table to modify
 * @param string $patch Name of the patch file to apply
-* @param string $fullpath Whether to treat $patch path as relative or 
not, defaults to false
+* @param string|bool $fullpath Whether to treat $patch path as 
relative or not, defaults to false
 * @return bool False if this was skipped because of schema changes 
being skipped
 */
-   public function modifyTable( $table, $patch,  $fullpath = false ) {
+   public function modifyTable( $table, $patch, $fullpath = false ) {
if ( !$this->doTable( $table ) ) {
return true;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/370226
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied34a05b2043a3354ff0629d8bb47a1176d8a74e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits