Awight has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402163 )

Change subject: Add an "unless" condition to npm downgrade
......................................................................

Add an "unless" condition to npm downgrade

This was running on every provision.

Change-Id: Iaedae6fe7c51e6cc02383a4e78388498f7c446d9
---
M puppet/modules/npm/manifests/init.pp
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vagrant 
refs/changes/63/402163/1

diff --git a/puppet/modules/npm/manifests/init.pp 
b/puppet/modules/npm/manifests/init.pp
index dde3fdd..85dc77b 100644
--- a/puppet/modules/npm/manifests/init.pp
+++ b/puppet/modules/npm/manifests/init.pp
@@ -46,6 +46,7 @@
     # Although the ticket is closed, the issue is still present, so downgrade 
to npm 2
     exec { 'downgrade_npm':
       command => '/usr/bin/npm install -g npm@latest-2',
+      unless  => '/usr/bin/npm --version | grep -qE "^2[.]"',
       user    => 'root',
       require => [
           Package['nodejs'],

-- 
To view, visit https://gerrit.wikimedia.org/r/402163
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaedae6fe7c51e6cc02383a4e78388498f7c446d9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Awight <awi...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to