Huji has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368335 )
Change subject: WIP: AbuseLog details page should link to the triggered version of the filter ...................................................................... WIP: AbuseLog details page should link to the triggered version of the filter Bug: T52806 Change-Id: Idf745db264ece2ef2d8ef900a5a6aef4676958d2 --- M special/SpecialAbuseLog.php 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AbuseFilter refs/changes/35/368335/1 diff --git a/special/SpecialAbuseLog.php b/special/SpecialAbuseLog.php index 853424b..35789dc 100644 --- a/special/SpecialAbuseLog.php +++ b/special/SpecialAbuseLog.php @@ -562,7 +562,19 @@ ->numParams( $globalIndex )->escaped(); $filterLink = Linker::makeExternalLink( $globalURL, $linkText ); } else { - $title = SpecialPage::getTitleFor( 'AbuseFilter', $row->afl_filter ); + // Which version of the filter was in use at the time of the logged action? + $dbr = wfGetDB( DB_SLAVE ); + $triggeredRev = $dbr->selectRow( + [ 'abuse_filter_history' ], + 'MAX(afh_id) AS item', + [ + 'afh_filter' => $row->afl_filter, + 'afh_timestamp <' . $dbr->addQuotes( $row->afl_timestamp ), + ], + __METHOD__ + ); + + $title = SpecialPage::getTitleFor( 'AbuseFilter', $row->afl_filter . '/item/' . $triggeredRev->item); $linkText = $this->msg( 'abusefilter-log-detailedentry-local' ) ->numParams( $row->afl_filter )->text(); $filterLink = $linkRenderer->makeKnownLink( $title, $linkText ); -- To view, visit https://gerrit.wikimedia.org/r/368335 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idf745db264ece2ef2d8ef900a5a6aef4676958d2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/AbuseFilter Gerrit-Branch: master Gerrit-Owner: Huji <huji.h...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits