jenkins-bot has submitted this change and it was merged. Change subject: Remove dependency on 'jquery' and 'mediawiki' modules ......................................................................
Remove dependency on 'jquery' and 'mediawiki' modules Follows-up ec77226078. Not needed since these are base modules, which are not valid dependencies (PHPUnit structure test fails). Change-Id: I2129de25d78ce68ab4aa875f62276dcf801a8216 --- M CategorySlideShow.php 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Krinkle: Looks good to me, approved jenkins-bot: Verified diff --git a/CategorySlideShow.php b/CategorySlideShow.php index 11404db..65c79ea 100644 --- a/CategorySlideShow.php +++ b/CategorySlideShow.php @@ -40,10 +40,8 @@ ), 'dependencies' => array( - 'mediawiki', 'mediawiki.Title', - 'mediawiki.api.query', - 'jquery', + 'mediawiki.api', 'jquery.ui.dialog', ), ) + $moduleInfo; -- To view, visit https://gerrit.wikimedia.org/r/272885 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2129de25d78ce68ab4aa875f62276dcf801a8216 Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/CategorySlideShow Gerrit-Branch: master Gerrit-Owner: Paladox <thomasmulhall...@yahoo.com> Gerrit-Reviewer: JanZerebecki <jan.wikime...@zerebecki.de> Gerrit-Reviewer: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: Paladox <thomasmulhall...@yahoo.com> Gerrit-Reviewer: Reedy <re...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits