[MediaWiki-commits] [Gerrit] mediawiki...CentralNotice[master]: Fix bad ternary

2016-09-22 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fix bad ternary
..


Fix bad ternary

We were mixing ternary and concatenation, and the operator binding was causing
garbage to spew.

Change-Id: Ie351dd78f92b30516feda83453da08586e15aad9
---
M special/SpecialBannerLoader.php
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Ejegg: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/special/SpecialBannerLoader.php b/special/SpecialBannerLoader.php
index 6f7967f..3c4dc39 100644
--- a/special/SpecialBannerLoader.php
+++ b/special/SpecialBannerLoader.php
@@ -169,8 +169,10 @@
function __construct( $bannerName = '(none provided)', $extraMsg = null 
) {
 
$this->message = get_called_class() .
-   " while loading banner: '{$bannerName}'" .
-   $extraMsg ? ". {$extraMsg}" : "";
+   " while loading banner: '{$bannerName}'";
+   if ( $extraMsg ) {
+   $this->message .= ". {$extraMsg}";
+   }
}
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/312139
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie351dd78f92b30516feda83453da08586e15aad9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Awight 
Gerrit-Reviewer: AndyRussG 
Gerrit-Reviewer: Cdentinger 
Gerrit-Reviewer: Ejegg 
Gerrit-Reviewer: Ssmith 
Gerrit-Reviewer: XenoRyet 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CentralNotice[master]: Fix bad ternary

2016-09-21 Thread Awight (Code Review) 
Awight has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/312139

Change subject: Fix bad ternary
..

Fix bad ternary

We were mixing ternary and concatenation, and the operator binding was causing
garbage to spew.

Change-Id: Ie351dd78f92b30516feda83453da08586e15aad9
---
M special/SpecialBannerLoader.php
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice 
refs/changes/39/312139/1

diff --git a/special/SpecialBannerLoader.php b/special/SpecialBannerLoader.php
index 6f7967f..3c4dc39 100644
--- a/special/SpecialBannerLoader.php
+++ b/special/SpecialBannerLoader.php
@@ -169,8 +169,10 @@
function __construct( $bannerName = '(none provided)', $extraMsg = null 
) {
 
$this->message = get_called_class() .
-   " while loading banner: '{$bannerName}'" .
-   $extraMsg ? ". {$extraMsg}" : "";
+   " while loading banner: '{$bannerName}'";
+   if ( $extraMsg ) {
+   $this->message .= ". {$extraMsg}";
+   }
}
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/312139
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie351dd78f92b30516feda83453da08586e15aad9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Awight 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits