[MediaWiki-commits] [Gerrit] mediawiki...Echo[wmf/1.30.0-wmf.10]: Fix layout regression in notification popup footer

2017-07-24 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366952 )

Change subject: Fix layout regression in notification popup footer
..


Fix layout regression in notification popup footer

Caused by a new margin rule in OOUI.

Bug: T171302
Change-Id: I5746d9e6a2daa2b0d18e76a99e67c8fdaa1464d6
(cherry picked from commit 0bf4861d929a21d4f80a1a466e04f04e61ea9642)
---
M modules/styles/mw.echo.ui.NotificationBadgeWidget.less
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/styles/mw.echo.ui.NotificationBadgeWidget.less 
b/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
index 2c2f0aa..183edf9 100644
--- a/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
+++ b/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
@@ -56,6 +56,9 @@
border-top: 1px solid #ddd;
width: 100%;
 
+   // Override the margins that OOUI suddenly 
added to popup footers (T171302)
+   margin: 0;
+
> .oo-ui-buttonGroupWidget {
display: block;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/366952
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5746d9e6a2daa2b0d18e76a99e67c8fdaa1464d6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: wmf/1.30.0-wmf.10
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Echo[wmf/1.30.0-wmf.10]: Fix layout regression in notification popup footer

2017-07-21 Thread Jforrester (Code Review) 
Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366952 )

Change subject: Fix layout regression in notification popup footer
..

Fix layout regression in notification popup footer

Caused by a new margin rule in OOUI.

Bug: T171302
Change-Id: I5746d9e6a2daa2b0d18e76a99e67c8fdaa1464d6
(cherry picked from commit 0bf4861d929a21d4f80a1a466e04f04e61ea9642)
---
M modules/styles/mw.echo.ui.NotificationBadgeWidget.less
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/52/366952/1

diff --git a/modules/styles/mw.echo.ui.NotificationBadgeWidget.less 
b/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
index 2c2f0aa..183edf9 100644
--- a/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
+++ b/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
@@ -56,6 +56,9 @@
border-top: 1px solid #ddd;
width: 100%;
 
+   // Override the margins that OOUI suddenly 
added to popup footers (T171302)
+   margin: 0;
+
> .oo-ui-buttonGroupWidget {
display: block;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/366952
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5746d9e6a2daa2b0d18e76a99e67c8fdaa1464d6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: wmf/1.30.0-wmf.10
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits