[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Show globe icon next to all links

2016-09-12 Thread JGirault (Code Review)
JGirault has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/309997

Change subject: Show globe icon next to all  links
..

Show globe icon next to all  links

* Uses MIT licensed globe icon from Ionicons icon pack,
  may be replaced once we have WMF icon.
* Provides a CSS class .no-icon to hide it.

Bug: T145176
Change-Id: Iddb86055eb71b258829ca3f14fa8292335f41acd
---
A styles/images/COPYING
A styles/images/ios-world-outline.png
A styles/images/ios-world-outline.svg
M styles/kartographer.less
4 files changed, 40 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Kartographer 
refs/changes/97/309997/1

diff --git a/styles/images/COPYING b/styles/images/COPYING
new file mode 100644
index 000..10d27d5
--- /dev/null
+++ b/styles/images/COPYING
@@ -0,0 +1,3 @@
+== ios-world-outline.svg ==
+Free to use and licensed under MIT from Ionicons 
https://github.com/driftyco/ionicons/blob/master/src/ios-world-outline.svg
+The ios-world-outline.png is generated for the SVG file for legacy browser 
support.
\ No newline at end of file
diff --git a/styles/images/ios-world-outline.png 
b/styles/images/ios-world-outline.png
new file mode 100644
index 000..077e810
--- /dev/null
+++ b/styles/images/ios-world-outline.png
Binary files differ
diff --git a/styles/images/ios-world-outline.svg 
b/styles/images/ios-world-outline.svg
new file mode 100644
index 000..2679e98
--- /dev/null
+++ b/styles/images/ios-world-outline.svg
@@ -0,0 +1,22 @@
+
+
+http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd;>
+http://www.w3.org/2000/svg; 
xmlns:xlink="http://www.w3.org/1999/xlink; x="0px" y="0px"
+width="512px" height="512px" viewBox="0 0 512 512" 
style="enable-background:new 0 0 512 512;" xml:space="preserve">
+
+
diff --git a/styles/kartographer.less b/styles/kartographer.less
index 853499e..e288d9d 100644
--- a/styles/kartographer.less
+++ b/styles/kartographer.less
@@ -1,3 +1,5 @@
+@import 'mediawiki.mixins';
+
 .mw-kartographer-mapDialog-map {
position: absolute;
top: 0;
@@ -15,6 +17,19 @@
 a.mw-kartographer-link {
display: inline;
cursor: pointer;
+
+   background-position: center right;
+   background-repeat: no-repeat;
+   .background-image-svg('images/ios-world-outline.svg', 
'images/ios-world-outline.png');
+   padding-right: 17px;
+   margin-right: 2px;
+   background-size: 16px 16px;
+
+   &.no-icon {
+   background: none;
+   padding-right: 0;
+   margin-right: 0;
+   }
 }
 
 a.mw-kartographer-autostyled {

-- 
To view, visit https://gerrit.wikimedia.org/r/309997
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iddb86055eb71b258829ca3f14fa8292335f41acd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: master
Gerrit-Owner: JGirault 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Show globe icon next to all links

2016-09-12 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Show globe icon next to all  links
..


Show globe icon next to all  links

* Uses MIT licensed globe icon from Ionicons icon pack,
  may be replaced once we have WMF icon.
* Provides a CSS class .no-icon to hide it.

Bug: T145176
Change-Id: Iddb86055eb71b258829ca3f14fa8292335f41acd
---
A styles/images/COPYING
A styles/images/ios-world-outline.png
A styles/images/ios-world-outline.svg
M styles/kartographer.less
4 files changed, 41 insertions(+), 0 deletions(-)

Approvals:
  Yurik: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/styles/images/COPYING b/styles/images/COPYING
new file mode 100644
index 000..10d27d5
--- /dev/null
+++ b/styles/images/COPYING
@@ -0,0 +1,3 @@
+== ios-world-outline.svg ==
+Free to use and licensed under MIT from Ionicons 
https://github.com/driftyco/ionicons/blob/master/src/ios-world-outline.svg
+The ios-world-outline.png is generated for the SVG file for legacy browser 
support.
\ No newline at end of file
diff --git a/styles/images/ios-world-outline.png 
b/styles/images/ios-world-outline.png
new file mode 100644
index 000..7e3944a
--- /dev/null
+++ b/styles/images/ios-world-outline.png
Binary files differ
diff --git a/styles/images/ios-world-outline.svg 
b/styles/images/ios-world-outline.svg
new file mode 100644
index 000..16b5496
--- /dev/null
+++ b/styles/images/ios-world-outline.svg
@@ -0,0 +1,22 @@
+
+
+http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd;>
+http://www.w3.org/2000/svg; 
xmlns:xlink="http://www.w3.org/1999/xlink; x="0px" y="0px"
+width="512px" height="512px" viewBox="0 0 512 512" 
style="enable-background:new 0 0 512 512;" xml:space="preserve">
+
+
diff --git a/styles/kartographer.less b/styles/kartographer.less
index 853499e..1e387b0 100644
--- a/styles/kartographer.less
+++ b/styles/kartographer.less
@@ -1,3 +1,5 @@
+@import 'mediawiki.mixins';
+
 .mw-kartographer-mapDialog-map {
position: absolute;
top: 0;
@@ -15,6 +17,19 @@
 a.mw-kartographer-link {
display: inline;
cursor: pointer;
+
+   background-position: center right;
+   background-repeat: no-repeat;
+   .background-image-svg('images/ios-world-outline.svg', 
'images/ios-world-outline.png');
+   padding-right: 17px;
+   margin-right: 2px;
+   background-size: 16px 16px;
+
+   &.no-icon:not(.mw-kartographer-autostyled) {
+   background: none;
+   padding-right: 0;
+   margin-right: 0;
+   }
 }
 
 a.mw-kartographer-autostyled {
@@ -32,6 +47,7 @@
line-height: 1;
text-align: center;
 }
+
 a.mw-kartographer-autostyled:visited {
color: #fff;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/309997
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iddb86055eb71b258829ca3f14fa8292335f41acd
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: master
Gerrit-Owner: JGirault 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: Kaldari 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: Yurik 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits