Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405747 )
Change subject: Fix NWE integration to use new tempWikitextEditor
......................................................................
Fix NWE integration to use new tempWikitextEditor
Bug: T185279
Depends-On: I3678996bcf644cc889dd168ac3ce48b5c3633ec1
Change-Id: I31a21e10b3fcd88fbce6881475f02a9d37df39c2
---
M modules/ext.linter.edit.js
1 file changed, 3 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Linter
refs/changes/47/405747/1
diff --git a/modules/ext.linter.edit.js b/modules/ext.linter.edit.js
index 63a3c01..619c9c3 100644
--- a/modules/ext.linter.edit.js
+++ b/modules/ext.linter.edit.js
@@ -7,19 +7,9 @@
if ( $textbox.length ) {
$textbox.focus().textSelection( 'setSelection',
{ start: location[ 0 ], end: location[ 1 ] } );
}
- // Register NWE code should it be loaded
- // TODO: We should somehow force source mode if VE is
opened
- mw.hook( 've.activationComplete' ).add( function () {
- // Selection is reset on a setTimeout after
activation, so wait for that.
- setTimeout( function () {
- var range,
- surface =
ve.init.target.getSurface();
-
- if ( surface.getMode() === 'source' ) {
- range =
surface.getModel().getRangeFromSourceOffsets( location[ 0 ], location[ 1 ] );
-
surface.getModel().setLinearSelection( range );
- }
- } );
+ mw.hook( 've.tempWikitextReady' ).add( function () {
+ mw.libs.ve.tempWikitextEditor.$element[ 0
].setSelectionRange( location[ 0 ], location[ 1 ] );
+ mw.libs.ve.tempWikitextEditor.focus();
} );
}
} );
--
To view, visit https://gerrit.wikimedia.org/r/405747
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I31a21e10b3fcd88fbce6881475f02a9d37df39c2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Linter
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
