[MediaWiki-commits] [Gerrit] mediawiki...Math[master]: getSelectedItem() -> findSelectedItem()

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404671 )

Change subject: getSelectedItem() -> findSelectedItem()
..


getSelectedItem() -> findSelectedItem()

Change-Id: I6ddf1ab488774f22fd566846c38483dcaf35ab27
---
M modules/ve-math/ve.ui.MWLatexDialog.js
M modules/ve-math/ve.ui.MWLatexInspector.js
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/modules/ve-math/ve.ui.MWLatexDialog.js 
b/modules/ve-math/ve.ui.MWLatexDialog.js
index 402976d..5434106 100644
--- a/modules/ve-math/ve.ui.MWLatexDialog.js
+++ b/modules/ve-math/ve.ui.MWLatexDialog.js
@@ -254,7 +254,7 @@
ve.ui.MWLatexDialog.super.prototype.updateMwData.call( this, mwData );
 
// Get data from dialog
-   display = this.displaySelect.getSelectedItem().getData();
+   display = this.displaySelect.findSelectedItem().getData();
id = this.idInput.getValue();
 
// Update attributes
diff --git a/modules/ve-math/ve.ui.MWLatexInspector.js 
b/modules/ve-math/ve.ui.MWLatexInspector.js
index b343b34..53af4a3 100644
--- a/modules/ve-math/ve.ui.MWLatexInspector.js
+++ b/modules/ve-math/ve.ui.MWLatexInspector.js
@@ -116,7 +116,7 @@
// Parent method
ve.ui.MWLatexInspector.super.prototype.updateMwData.call( this, mwData 
);
 
-   display = this.displaySelect.getSelectedItem().getData();
+   display = this.displaySelect.findSelectedItem().getData();
id = this.idInput.getValue();
 
mwData.attrs.display = display !== 'default' ? display : undefined;

-- 
To view, visit https://gerrit.wikimedia.org/r/404671
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6ddf1ab488774f22fd566846c38483dcaf35ab27
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Math
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Physikerwelt 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Math[master]: getSelectedItem() -> findSelectedItem()

[Esanders (Code Review)]

Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404671 )

Change subject: getSelectedItem() -> findSelectedItem()
..

getSelectedItem() -> findSelectedItem()

Change-Id: I6ddf1ab488774f22fd566846c38483dcaf35ab27
---
M modules/ve-math/ve.ui.MWLatexDialog.js
M modules/ve-math/ve.ui.MWLatexInspector.js
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Math 
refs/changes/71/404671/1

diff --git a/modules/ve-math/ve.ui.MWLatexDialog.js 
b/modules/ve-math/ve.ui.MWLatexDialog.js
index 402976d..5434106 100644
--- a/modules/ve-math/ve.ui.MWLatexDialog.js
+++ b/modules/ve-math/ve.ui.MWLatexDialog.js
@@ -254,7 +254,7 @@
ve.ui.MWLatexDialog.super.prototype.updateMwData.call( this, mwData );
 
// Get data from dialog
-   display = this.displaySelect.getSelectedItem().getData();
+   display = this.displaySelect.findSelectedItem().getData();
id = this.idInput.getValue();
 
// Update attributes
diff --git a/modules/ve-math/ve.ui.MWLatexInspector.js 
b/modules/ve-math/ve.ui.MWLatexInspector.js
index b343b34..53af4a3 100644
--- a/modules/ve-math/ve.ui.MWLatexInspector.js
+++ b/modules/ve-math/ve.ui.MWLatexInspector.js
@@ -116,7 +116,7 @@
// Parent method
ve.ui.MWLatexInspector.super.prototype.updateMwData.call( this, mwData 
);
 
-   display = this.displaySelect.getSelectedItem().getData();
+   display = this.displaySelect.findSelectedItem().getData();
id = this.idInput.getValue();
 
mwData.attrs.display = display !== 'default' ? display : undefined;

-- 
To view, visit https://gerrit.wikimedia.org/r/404671
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ddf1ab488774f22fd566846c38483dcaf35ab27
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Math
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits