Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368114 )

Change subject: Hygiene: Toast selector should be more flexible
......................................................................

Hygiene: Toast selector should be more flexible

A toast can carry other classes.
I have a hunch that using class here is wrong as class will not
match a toast with other classes.

Bug: T170890
Change-Id: I9fbb21f8d262890d4c9d2a508351f33fe2023297
---
M tests/browser/features/support/pages/article_page.rb
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/14/368114/1

diff --git a/tests/browser/features/support/pages/article_page.rb 
b/tests/browser/features/support/pages/article_page.rb
index 064e9a7..e7c14e8 100644
--- a/tests/browser/features/support/pages/article_page.rb
+++ b/tests/browser/features/support/pages/article_page.rb
@@ -144,7 +144,7 @@
   div(:spinner_loading, class: 'spinner loading')
 
   # toast
-  div(:toast, class: 'mw-notification')
+  div(:toast, css: '.mw-notification')
 
   # loader
   div(:content_wrapper, id: 'content')

-- 
To view, visit https://gerrit.wikimedia.org/r/368114
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fbb21f8d262890d4c9d2a508351f33fe2023297
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to