jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/399465 )
Change subject: Catch another double-quote, this may change the behavior of the
three changes feeds.
..
Catch another double-quote, this may change the behavior of the three changes
feeds.
Change-Id: I9876698af12409ee3cbb8cd95876b9c3bb2342fd
---
M includes/Hooks.php
M tests/phpunit/includes/Hooks/ContributionsHookHandlerTest.php
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Ladsgroup: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Hooks.php b/includes/Hooks.php
index 43c3ec5..cb6b549 100644
--- a/includes/Hooks.php
+++ b/includes/Hooks.php
@@ -384,7 +384,7 @@
return;
}
// FIXME: This is not a "filter" but an undocumented side
effect of this function.
- $fields['ores_damaging_threshold'] = $dbr->addQuotes(
$threshold );
+ $fields['ores_damaging_threshold'] = $threshold;
if ( $hidenondamaging ) {
// Filter out non-damaging edits.
diff --git a/tests/phpunit/includes/Hooks/ContributionsHookHandlerTest.php
b/tests/phpunit/includes/Hooks/ContributionsHookHandlerTest.php
index 554ffdf..9f0c9a5 100644
--- a/tests/phpunit/includes/Hooks/ContributionsHookHandlerTest.php
+++ b/tests/phpunit/includes/Hooks/ContributionsHookHandlerTest.php
@@ -74,7 +74,7 @@
],
'fields' => [
'ores_damaging_score' =>
'ores_damaging_cls.oresc_probability',
- 'ores_damaging_threshold' => "'0.16'"
+ 'ores_damaging_threshold' => 0.16,
],
'conds' => [],
'join_conds' => [
--
To view, visit https://gerrit.wikimedia.org/r/399465
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9876698af12409ee3cbb8cd95876b9c3bb2342fd
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/ORES
Gerrit-Branch: master
Gerrit-Owner: Awight
Gerrit-Reviewer: Catrope
Gerrit-Reviewer: Ladsgroup
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
