[MediaWiki-commits] [Gerrit] mediawiki...PageAssessments[master]: Only update assessment data when talk pages are saved
jenkins-bot has submitted this change and it was merged. Change subject: Only update assessment data when talk pages are saved .. Only update assessment data when talk pages are saved Bug: T147906 Change-Id: Iacd4c46429fdfda344c968af9bd306454f1bb878 --- M PageAssessments.hooks.php 1 file changed, 17 insertions(+), 13 deletions(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified diff --git a/PageAssessments.hooks.php b/PageAssessments.hooks.php index 5c6dd5c..b9aec25 100644 --- a/PageAssessments.hooks.php +++ b/PageAssessments.hooks.php @@ -31,24 +31,28 @@ } /** -* Insert assessment records after page is saved +* Update assessment records after talk page is saved * @param LinksUpdate $linksUpdate * @param mixed $ticket */ public static function onLinksUpdateComplete( &$linksUpdate, $ticket = null ) { - $pOut = $linksUpdate->getParserOutput(); - if ( $pOut->getExtensionData( 'ext-pageassessment-assessmentdata' ) !== null ) { - $assessmentData = $pOut->getExtensionData( 'ext-pageassessment-assessmentdata' ); - } else { - // Even if there is no assessment data, we still need to run doUpdates - // in case any assessment data was deleted from the page. - $assessmentData = []; - } $title = $linksUpdate->getTitle(); - // In most cases $title will be a talk page, but we want to associate the - // assessment data with the subject page. - $subjectTitle = $title->getSubjectPage(); - PageAssessmentsBody::doUpdates( $subjectTitle, $assessmentData, $ticket ); + // This assumes that the assessment parser function is only used on talk pages. + // See T147906 for why assessments are not supported in either namespace. + if ( $title->getNamespace() === NS_TALK ) { + $pOut = $linksUpdate->getParserOutput(); + if ( $pOut->getExtensionData( 'ext-pageassessment-assessmentdata' ) !== null ) { + $assessmentData = $pOut->getExtensionData( 'ext-pageassessment-assessmentdata' ); + } else { + // Even if there is no assessment data, we still need to run doUpdates + // in case any assessment data was deleted from the page. + $assessmentData = []; + } + // The title is a talk page, but we want to associate the assessment data + // with the subject page. + $subjectTitle = $title->getSubjectPage(); + PageAssessmentsBody::doUpdates( $subjectTitle, $assessmentData, $ticket ); + } } /** -- To view, visit https://gerrit.wikimedia.org/r/315458 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacd4c46429fdfda344c968af9bd306454f1bb878 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/PageAssessments Gerrit-Branch: master Gerrit-Owner: KaldariGerrit-Reviewer: Aaron Schulz Gerrit-Reviewer: MusikAnimal Gerrit-Reviewer: Niharika29 Gerrit-Reviewer: Samwilson Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...PageAssessments[master]: Only update assessment data when talk pages are saved
Kaldari has uploaded a new change for review. https://gerrit.wikimedia.org/r/315458 Change subject: Only update assessment data when talk pages are saved .. Only update assessment data when talk pages are saved Bug: T147906 Change-Id: Iacd4c46429fdfda344c968af9bd306454f1bb878 --- M PageAssessments.hooks.php 1 file changed, 17 insertions(+), 13 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageAssessments refs/changes/58/315458/1 diff --git a/PageAssessments.hooks.php b/PageAssessments.hooks.php index 5c6dd5c..b9aec25 100644 --- a/PageAssessments.hooks.php +++ b/PageAssessments.hooks.php @@ -31,24 +31,28 @@ } /** -* Insert assessment records after page is saved +* Update assessment records after talk page is saved * @param LinksUpdate $linksUpdate * @param mixed $ticket */ public static function onLinksUpdateComplete( &$linksUpdate, $ticket = null ) { - $pOut = $linksUpdate->getParserOutput(); - if ( $pOut->getExtensionData( 'ext-pageassessment-assessmentdata' ) !== null ) { - $assessmentData = $pOut->getExtensionData( 'ext-pageassessment-assessmentdata' ); - } else { - // Even if there is no assessment data, we still need to run doUpdates - // in case any assessment data was deleted from the page. - $assessmentData = []; - } $title = $linksUpdate->getTitle(); - // In most cases $title will be a talk page, but we want to associate the - // assessment data with the subject page. - $subjectTitle = $title->getSubjectPage(); - PageAssessmentsBody::doUpdates( $subjectTitle, $assessmentData, $ticket ); + // This assumes that the assessment parser function is only used on talk pages. + // See T147906 for why assessments are not supported in either namespace. + if ( $title->getNamespace() === NS_TALK ) { + $pOut = $linksUpdate->getParserOutput(); + if ( $pOut->getExtensionData( 'ext-pageassessment-assessmentdata' ) !== null ) { + $assessmentData = $pOut->getExtensionData( 'ext-pageassessment-assessmentdata' ); + } else { + // Even if there is no assessment data, we still need to run doUpdates + // in case any assessment data was deleted from the page. + $assessmentData = []; + } + // The title is a talk page, but we want to associate the assessment data + // with the subject page. + $subjectTitle = $title->getSubjectPage(); + PageAssessmentsBody::doUpdates( $subjectTitle, $assessmentData, $ticket ); + } } /** -- To view, visit https://gerrit.wikimedia.org/r/315458 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iacd4c46429fdfda344c968af9bd306454f1bb878 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/PageAssessments Gerrit-Branch: master Gerrit-Owner: Kaldari___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits