Pmiazga has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/365028 )
Change subject: Set up phpcs to detect all code style violations
......................................................................
Set up phpcs to detect all code style violations
Bug: T170583
Change-Id: I4ae8e4f1ca6837695e813b16f3109406e63201b3
---
M composer.json
A phpcs.xml
2 files changed, 26 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageImages
refs/changes/28/365028/1
diff --git a/composer.json b/composer.json
index 686b65b..65fd159 100644
--- a/composer.json
+++ b/composer.json
@@ -1,11 +1,14 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "jakub-onderka/php-console-highlighter": "0.3.2"
+ "jakub-onderka/php-console-highlighter": "0.3.2",
+ "mediawiki/mediawiki-codesniffer": "0.10.0"
},
"scripts": {
"test": [
- "parallel-lint . --exclude vendor"
+ "parallel-lint . --exclude vendor",
+ "phpcs -p -s"
]
}
}
+
diff --git a/phpcs.xml b/phpcs.xml
new file mode 100644
index 0000000..3d8ee25
--- /dev/null
+++ b/phpcs.xml
@@ -0,0 +1,21 @@
+<?xml version="1.0"?>
+<ruleset>
+ <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ </rule>
+ <rule ref="Generic.Files.LineLength">
+ <exclude-pattern>MobileFrontend.alias.php</exclude-pattern>
+ </rule>
+ <file>.</file>
+ <arg name="extensions" value="php,php5,inc"/>
+ <arg name="encoding" value="UTF-8"/>
+ <exclude-pattern>vendor</exclude-pattern>
+ <exclude-pattern>node_modules</exclude-pattern>
+
+ <rule ref="Squiz.Functions.FunctionDeclarationArgumentSpacing">
+ <properties>
+ <property name="equalsSpacing" value="1" />
+ <property name="requiredSpacesAfterOpen"
value="1"/>
+ <property name="requiredSpacesBeforeClose"
value="1" />
+ </properties>
+ </rule>
+</ruleset>
--
To view, visit https://gerrit.wikimedia.org/r/365028
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ae8e4f1ca6837695e813b16f3109406e63201b3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageImages
Gerrit-Branch: master
Gerrit-Owner: Pmiazga <pmia...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
