[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Do not use keyword `const` as it's part of ES6 syntax

2017-08-29 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/374552 )

Change subject: Do not use keyword `const` as it's part of ES6 syntax
..


Do not use keyword `const` as it's part of ES6 syntax

Changes:
  - instead of const use var

Bug: T174424
Change-Id: I3d786614b5acbfe9a05c332edd3a14c2e5afa417
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/constants.js
3 files changed, 9 insertions(+), 8 deletions(-)

Approvals:
  jenkins-bot: Verified
  Phuedx: Looks good to me, approved




-- 
To view, visit https://gerrit.wikimedia.org/r/374552
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3d786614b5acbfe9a05c332edd3a14c2e5afa417
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Pmiazga 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Phuedx 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Do not use keyword `const` as it's part of ES6 syntax

2017-08-29 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/374552 )

Change subject: Do not use keyword `const` as it's part of ES6 syntax
..

Do not use keyword `const` as it's part of ES6 syntax

Changes:
  - instead of const use var

Bug: T174424
Change-Id: I3d786614b5acbfe9a05c332edd3a14c2e5afa417
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/constants.js
3 files changed, 9 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/52/374552/1


-- 
To view, visit https://gerrit.wikimedia.org/r/374552
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d786614b5acbfe9a05c332edd3a14c2e5afa417
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Pmiazga 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits