[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Override eventLogging to enabled when debug flag is on

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/362434 )

Change subject: Override eventLogging to enabled when debug flag is on
..


Override eventLogging to enabled when debug flag is on

In order to debug the EventLogging instrumentation in production
environments, we want to be able to bucket ourselves at will.
When the debug flag (?debug=true) is passed send all events
for given page view.

Bug: T168847
Change-Id: Id1b13b0ecaa791b4f26be4d1151bdbbe5270b64d
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/instrumentation/eventLogging.js
M tests/node-qunit/instrumentation/eventLogging.test.js
4 files changed, 16 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Phuedx: Looks good to me, approved




-- 
To view, visit https://gerrit.wikimedia.org/r/362434
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id1b13b0ecaa791b4f26be4d1151bdbbe5270b64d
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Pmiazga 
Gerrit-Reviewer: BarryTheBrowserTestBot 
Gerrit-Reviewer: Frankiebot 
Gerrit-Reviewer: Phuedx 
Gerrit-Reviewer: Pmiazga 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Override eventLogging to enabled when debug flag is on

[Pmiazga (Code Review)]

Pmiazga has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/362434 )

Change subject: Override eventLogging to enabled when debug flag is on
..

Override eventLogging to enabled when debug flag is on

In order to debug the EventLogging instrumentation in production
environments, we want to be able to bucket ourselves at will.
When the debug flag (?debug=true) is passed send all events
for given page view.

Bug: T168847
Change-Id: Id1b13b0ecaa791b4f26be4d1151bdbbe5270b64d
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/instrumentation/eventLogging.js
M tests/node-qunit/instrumentation/eventLogging.test.js
4 files changed, 16 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/34/362434/1


-- 
To view, visit https://gerrit.wikimedia.org/r/362434
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1b13b0ecaa791b4f26be4d1151bdbbe5270b64d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Pmiazga 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits