[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: ESLint should ignore vendor folder

[Pmiazga (Code Review)]

Pmiazga has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367672 )

Change subject: ESLint should ignore vendor folder
..


ESLint should ignore vendor folder

On my machine `npm test` fails with a lot of ESLint errors for files in vendor 
folder. I guess mediawiki-vagrant creates the folder.

Change-Id: I5466ad8c490b39bef9a31f5442fecd2d11895b80
Depends-On: Ib7f0bd15dd0a9255e1e5140907e800478b658b92
---
M Gruntfile.js
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Pmiazga: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Gruntfile.js b/Gruntfile.js
index 91e4fec..8651c9c 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -12,7 +12,8 @@
all: [
'**/*.js',
'!node_modules/**',
-   '!resources/ext.relatedArticles.lib/**'
+   '!resources/ext.relatedArticles.lib/**',
+   '!vendor/**'
]
},
banana: conf.MessagesDirs,

-- 
To view, visit https://gerrit.wikimedia.org/r/367672
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5466ad8c490b39bef9a31f5442fecd2d11895b80
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/RelatedArticles
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: Phuedx 
Gerrit-Reviewer: Pmiazga 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: ESLint should ignore vendor folder

[Zfilipin (Code Review)]

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/367672 )

Change subject: ESLint should ignore vendor folder
..

ESLint should ignore vendor folder

On my machine `npm test` fails with a lot of ESLint errors for files in vendor 
folder. I guess mediawiki-vagrant creates the folder.

Change-Id: I5466ad8c490b39bef9a31f5442fecd2d11895b80
---
M Gruntfile.js
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RelatedArticles 
refs/changes/72/367672/1

diff --git a/Gruntfile.js b/Gruntfile.js
index 91e4fec..8651c9c 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -12,7 +12,8 @@
all: [
'**/*.js',
'!node_modules/**',
-   '!resources/ext.relatedArticles.lib/**'
+   '!resources/ext.relatedArticles.lib/**',
+   '!vendor/**'
]
},
banana: conf.MessagesDirs,

-- 
To view, visit https://gerrit.wikimedia.org/r/367672
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5466ad8c490b39bef9a31f5442fecd2d11895b80
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RelatedArticles
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits