[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Hygiene: Remove unnecessary variable

2017-07-14 Thread Jdlrobson (Code Review) 
Jdlrobson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365417 )

Change subject: Hygiene: Remove unnecessary variable
..


Hygiene: Remove unnecessary variable

Improves readability...

Change-Id: Ib0e9cbc083e6c0a384c81815b470063698e0595f
---
M resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js
1 file changed, 3 insertions(+), 5 deletions(-)

Approvals:
  Jdlrobson: Verified; Looks good to me, approved



diff --git 
a/resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js 
b/resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js
index ba49682..5bb8b16 100644
--- a/resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js
+++ b/resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js
@@ -63,8 +63,7 @@
 * @return {jQuery.Promise}
 */
RelatedPagesGateway.prototype.getForCurrentPage = function ( limit ) {
-   var apiLimit,
-   parameters = {
+   var parameters = {
action: 'query',
formatversion: 2,
prop: 'pageimages|pageterms',
@@ -81,13 +80,12 @@
 
parameters.titles = relatedPages;
} else if ( this.useCirrusSearch ) {
-   apiLimit = limit;
-   parameters.pilimit = apiLimit;
+   parameters.pilimit = limit;
 
parameters.generator = 'search';
parameters.gsrsearch = 'morelike:' + this.currentPage;
parameters.gsrnamespace = '0';
-   parameters.gsrlimit = apiLimit;
+   parameters.gsrlimit = limit;
parameters.gsrqiprofile = 'classic_noboostlinks';
 
// Currently, if you're logged in, then the API uses 
your language by default ard so responses

-- 
To view, visit https://gerrit.wikimedia.org/r/365417
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0e9cbc083e6c0a384c81815b470063698e0595f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RelatedArticles
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Hygiene: Remove unnecessary variable

2017-07-14 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365417 )

Change subject: Hygiene: Remove unnecessary variable
..

Hygiene: Remove unnecessary variable

Improves readability...

Change-Id: Ib0e9cbc083e6c0a384c81815b470063698e0595f
---
M resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js
1 file changed, 3 insertions(+), 5 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RelatedArticles 
refs/changes/17/365417/1

diff --git 
a/resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js 
b/resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js
index ba49682..5bb8b16 100644
--- a/resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js
+++ b/resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js
@@ -63,8 +63,7 @@
 * @return {jQuery.Promise}
 */
RelatedPagesGateway.prototype.getForCurrentPage = function ( limit ) {
-   var apiLimit,
-   parameters = {
+   var parameters = {
action: 'query',
formatversion: 2,
prop: 'pageimages|pageterms',
@@ -81,13 +80,12 @@
 
parameters.titles = relatedPages;
} else if ( this.useCirrusSearch ) {
-   apiLimit = limit;
-   parameters.pilimit = apiLimit;
+   parameters.pilimit = limit;
 
parameters.generator = 'search';
parameters.gsrsearch = 'morelike:' + this.currentPage;
parameters.gsrnamespace = '0';
-   parameters.gsrlimit = apiLimit;
+   parameters.gsrlimit = limit;
parameters.gsrqiprofile = 'classic_noboostlinks';
 
// Currently, if you're logged in, then the API uses 
your language by default ard so responses

-- 
To view, visit https://gerrit.wikimedia.org/r/365417
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0e9cbc083e6c0a384c81815b470063698e0595f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RelatedArticles
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits