[MediaWiki-commits] [Gerrit] mediawiki...SubpageSortkey[master]: Improve some parameter docs

2018-01-07 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/402639 )

Change subject: Improve some parameter docs
..


Improve some parameter docs

Change-Id: I48b8a33f1fe37cddbe4a1fd7d5fed14e4026691d
---
M .phpcs.xml
M SubpageSortkey_body.php
2 files changed, 9 insertions(+), 9 deletions(-)

Approvals:
  Brian Wolff: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/.phpcs.xml b/.phpcs.xml
index 3773e8f..90e8108 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,13 +1,10 @@
 
 

-   
-   
+   


.

-   
-   vendor
-   node_modules
+   
 
diff --git a/SubpageSortkey_body.php b/SubpageSortkey_body.php
index b903e8a..f5cfb40 100644
--- a/SubpageSortkey_body.php
+++ b/SubpageSortkey_body.php
@@ -14,6 +14,9 @@
 *
 * Another example: Configuration -3..-1 turns 1/2/3/4/5 -> 3/4
 * and -3.. turns 1/2/3/4/5 -> 3/4/5
+* @param Title $title
+* @param string &$unprefixed
+* @return true
 */
public static function onGetDefaultSortkey( $title, &$unprefixed ) {
global $wgSubpageSortkeyDefault,
@@ -60,10 +63,10 @@
}
 
/**
-* @param $index Int starting index of subpage.
-* @param $count Int how many elements, or false to denote all
-* @param $title Title
-* @return array of subpages (strings)
+* @param int $index starting index of subpage.
+* @param int $count how many elements, or false to denote all
+* @param Title $title
+* @return string[] array of subpages
 */
private static function getSubpage( $index, $count, $title ) {
$subpages = explode( '/', $title->getText() );

-- 
To view, visit https://gerrit.wikimedia.org/r/402639
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I48b8a33f1fe37cddbe4a1fd7d5fed14e4026691d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SubpageSortkey
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Brian Wolff 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...SubpageSortkey[master]: Improve some parameter docs

2018-01-07 Thread Umherirrender (Code Review) 
Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402639 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I48b8a33f1fe37cddbe4a1fd7d5fed14e4026691d
---
M .phpcs.xml
M SubpageSortkey_body.php
2 files changed, 9 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SubpageSortkey 
refs/changes/39/402639/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 3773e8f..90e8108 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,13 +1,10 @@
 
 

-   
-   
+   


.

-   
-   vendor
-   node_modules
+   
 
diff --git a/SubpageSortkey_body.php b/SubpageSortkey_body.php
index b903e8a..f5cfb40 100644
--- a/SubpageSortkey_body.php
+++ b/SubpageSortkey_body.php
@@ -14,6 +14,9 @@
 *
 * Another example: Configuration -3..-1 turns 1/2/3/4/5 -> 3/4
 * and -3.. turns 1/2/3/4/5 -> 3/4/5
+* @param Title $title
+* @param string &$unprefixed
+* @return true
 */
public static function onGetDefaultSortkey( $title, &$unprefixed ) {
global $wgSubpageSortkeyDefault,
@@ -60,10 +63,10 @@
}
 
/**
-* @param $index Int starting index of subpage.
-* @param $count Int how many elements, or false to denote all
-* @param $title Title
-* @return array of subpages (strings)
+* @param int $index starting index of subpage.
+* @param int $count how many elements, or false to denote all
+* @param Title $title
+* @return string[] array of subpages
 */
private static function getSubpage( $index, $count, $title ) {
$subpages = explode( '/', $title->getText() );

-- 
To view, visit https://gerrit.wikimedia.org/r/402639
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I48b8a33f1fe37cddbe4a1fd7d5fed14e4026691d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SubpageSortkey
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits