jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/364028 )
Change subject: Remove `position: absolute` from #p-logo element
......................................................................
Remove `position: absolute` from #p-logo element
This was inherited from Monobook (r2881, b52a2a1567).
The #mw-panel (sidebar) was at `top: 160px`.
The #p-logo was at `top: -160px`.
This looks hacky so I set #mw-panel `top: 0`.
Bug: T170053
Change-Id: Ifb99ff36e3a9c530c944df2ea0a6c75759045c1c
---
M components/navigation.less
M screen-hd.less
M variables.less
3 files changed, 2 insertions(+), 11 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, but someone else must approve
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/components/navigation.less b/components/navigation.less
index a74eda3..776ef35 100644
--- a/components/navigation.less
+++ b/components/navigation.less
@@ -60,9 +60,6 @@
/* Logo */
#p-logo {
- position: absolute;
- top: -160px;
- left: 0;
width: 10em;
height: 160px;
@@ -80,8 +77,7 @@
div#mw-panel {
font-size: @menu-main-font-size;
position: absolute;
- top: 160px;
- padding-top: 1em;
+ top: 0;
width: 10em;
left: 0;
@@ -135,7 +131,7 @@
/* First sidebar portlet. Not using :first-of-type for IE<=8 support. */
#p-logo + div.portal {
background-image: none;
- margin-top: 0;
+ margin-top: 1em;
h3 {
display: none;
}
diff --git a/screen-hd.less b/screen-hd.less
index 96c96cc..02c3fb8 100644
--- a/screen-hd.less
+++ b/screen-hd.less
@@ -6,9 +6,6 @@
margin-left: 11em;
padding: 1.25em 1.5em 1.5em 1.5em;
}
-#p-logo {
- left: @menu-main-logo-left;
-}
div#footer {
margin-left: 11em;
padding: 1.25em;
diff --git a/variables.less b/variables.less
index 1e67cb3..7a5d1e6 100755
--- a/variables.less
+++ b/variables.less
@@ -33,7 +33,5 @@
@menu-main-body-margin-left: 0.5em;
@menu-main-body-padding: 0.3em 0 0 0;
-@menu-main-logo-left: 0.5em;
-
// Personal menu
@menu-personal-font-size: 0.75em;
--
To view, visit https://gerrit.wikimedia.org/r/364028
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb99ff36e3a9c530c944df2ea0a6c75759045c1c
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Golopotw <golo...@gmail.com>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Fomafix <foma...@googlemail.com>
Gerrit-Reviewer: Golopotw <golo...@gmail.com>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
