[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Public API for the tempWikitextEditor

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/405746 )

Change subject: Public API for the tempWikitextEditor
..


Public API for the tempWikitextEditor

Allows users to know when the widget has been constructed,
and access it (e.g. to set an initial selection)

Bug: T185279
Change-Id: I3678996bcf644cc889dd168ac3ce48b5c3633ec1
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  DLynch: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js 
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
index 7ca66e2..0119981 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
@@ -137,6 +137,8 @@
// but hopefully this temporary textarea won't be visible for 
too long.
tempWikitextEditor.adjustSize().moveCursorToStart();
ve.track( 'mwedit.ready', { mode: 'source' } );
+   mw.libs.ve.tempWikitextEditor = tempWikitextEditor;
+   mw.hook( 've.wikitextInteractive' ).fire();
}
 
function syncTempWikitextEditor() {
@@ -161,7 +163,7 @@
function teardownTempWikitextEditor() {
// Destroy widget and placeholder
tempWikitextEditor.$element.remove();
-   tempWikitextEditor = null;
+   mw.libs.ve.tempWikitextEditor = tempWikitextEditor = null;
tempWikitextEditorData = null;
$toolbarPlaceholder.remove();
$toolbarPlaceholder = null;
@@ -392,6 +394,8 @@
if ( mode === 'visual' ) {
// 'mwedit.ready' has already been 
fired for source mode in setupTempWikitextEditor
ve.track( 'mwedit.ready', { mode: mode 
} );
+   } else if ( !tempWikitextEditor ) {
+   mw.hook( 've.wikitextInteractive' 
).fire();
}
ve.track( 'mwedit.loaded', { mode: mode } );
} )

-- 
To view, visit https://gerrit.wikimedia.org/r/405746
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3678996bcf644cc889dd168ac3ce48b5c3633ec1
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: DLynch 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Public API for the tempWikitextEditor

[Esanders (Code Review)]

Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405746 )

Change subject: Public API for the tempWikitextEditor
..

Public API for the tempWikitextEditor

Allows users to know when the widget has been constructed,
and access it (e.g. to set an initial selection)

Bug: T185279
Change-Id: I3678996bcf644cc889dd168ac3ce48b5c3633ec1
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/46/405746/1

diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js 
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
index a737d41..52037a9 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
@@ -141,6 +141,8 @@
// but hopefully this temporary textarea won't be visible for 
too long.
tempWikitextEditor.adjustSize().focus();
ve.track( 'mwedit.ready', { mode: 'source' } );
+   mw.libs.ve.tempWikitextEditor = tempWikitextEditor;
+   mw.hook( 've.tempWikitextReady' ).fire();
}
 
function teardownTempWikitextEditor() {
@@ -154,7 +156,7 @@
 
// Destroy widget and placeholder
tempWikitextEditor.$element.remove();
-   tempWikitextEditor = null;
+   mw.libs.ve.tempWikitextEditor = tempWikitextEditor = null;
$toolbarPlaceholder.remove();
$toolbarPlaceholder = null;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/405746
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3678996bcf644cc889dd168ac3ce48b5c3633ec1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits