[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Remove line breaks from gallery dialog captions

2017-03-10 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/342242 )

Change subject: Remove line breaks from gallery dialog captions
..


Remove line breaks from gallery dialog captions

A gallery tag is parsed line by line, so captions
(and other image data) should not contain line breaks

Bug: T153373
Change-Id: Ib1d1c18216d07c83b2d4358d2dda71c9d17e3e44
---
M modules/ve-mw/ui/widgets/ve.ui.MWGalleryItemWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWGalleryItemWidget.js 
b/modules/ve-mw/ui/widgets/ve.ui.MWGalleryItemWidget.js
index 674395a..be4d375 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWGalleryItemWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWGalleryItemWidget.js
@@ -82,7 +82,7 @@
  * @param {string} caption The caption
  */
 ve.ui.MWGalleryItemWidget.prototype.setCaption = function ( caption ) {
-   this.caption = caption;
+   this.caption = caption.replace( '\n', ' ' );
 };
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/342242
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1d1c18216d07c83b2d4358d2dda71c9d17e3e44
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Tchanders 
Gerrit-Reviewer: DLynch 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Remove line breaks from gallery dialog captions

2017-03-10 Thread Tchanders (Code Review) 
Tchanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/342242 )

Change subject: Remove line breaks from gallery dialog captions
..

Remove line breaks from gallery dialog captions

A gallery tag is parsed line by line, so captions
(and other image data) should not contain line breaks

Bug: T153373
Change-Id: Ib1d1c18216d07c83b2d4358d2dda71c9d17e3e44
---
M modules/ve-mw/ui/widgets/ve.ui.MWGalleryItemWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/42/342242/1

diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWGalleryItemWidget.js 
b/modules/ve-mw/ui/widgets/ve.ui.MWGalleryItemWidget.js
index 674395a..e93f227 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWGalleryItemWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWGalleryItemWidget.js
@@ -82,7 +82,7 @@
  * @param {string} caption The caption
  */
 ve.ui.MWGalleryItemWidget.prototype.setCaption = function ( caption ) {
-   this.caption = caption;
+   this.caption = caption.replace('\n', ' ');
 };
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/342242
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1d1c18216d07c83b2d4358d2dda71c9d17e3e44
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Tchanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits