[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[master]: Avoid deprecated LBFactory::singleton() in tests (#2)

2016-09-15 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Avoid deprecated LBFactory::singleton() in tests (#2)
..


Avoid deprecated LBFactory::singleton() in tests (#2)

Change-Id: Icc77f25a56b7574ebdde1ef927a9346d7996e826
---
M 
extensions/Wikibase/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/extensions/Wikibase/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php
 
b/extensions/Wikibase/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php
index ab0a78d..3abdfaa 100644
--- 
a/extensions/Wikibase/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php
+++ 
b/extensions/Wikibase/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php
@@ -13,6 +13,7 @@
 use Wikibase\Client\RecentChanges\RecentChangeFactory;
 use Wikibase\Client\WikibaseClient;
 use Wikimedia\Assert\Assert;
+use \MediaWiki\MediaWikiServices;
 
 /**
  * @since 0.5
@@ -90,7 +91,7 @@
return new self(
$context->getRequest(),
$context->getUser(),
-   LBFactory::singleton()->getMainLB(),
+   MediaWikiServices::getInstance()->getDBLoadBalancer(),
$specialPageName,
$settings->getSetting( 'showExternalRecentChanges' )
);

-- 
To view, visit https://gerrit.wikimedia.org/r/310878
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icc77f25a56b7574ebdde1ef927a9346d7996e826
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikidata
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: Tobias Gritschacher 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[master]: Avoid deprecated LBFactory::singleton() in tests (#2)

2016-09-15 Thread Aaron Schulz (Code Review) 
Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/310878

Change subject: Avoid deprecated LBFactory::singleton() in tests (#2)
..

Avoid deprecated LBFactory::singleton() in tests (#2)

Change-Id: Icc77f25a56b7574ebdde1ef927a9346d7996e826
---
M 
extensions/Wikibase/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikidata 
refs/changes/78/310878/1

diff --git 
a/extensions/Wikibase/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php
 
b/extensions/Wikibase/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php
index ab0a78d..3abdfaa 100644
--- 
a/extensions/Wikibase/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php
+++ 
b/extensions/Wikibase/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php
@@ -13,6 +13,7 @@
 use Wikibase\Client\RecentChanges\RecentChangeFactory;
 use Wikibase\Client\WikibaseClient;
 use Wikimedia\Assert\Assert;
+use \MediaWiki\MediaWikiServices;
 
 /**
  * @since 0.5
@@ -90,7 +91,7 @@
return new self(
$context->getRequest(),
$context->getUser(),
-   LBFactory::singleton()->getMainLB(),
+   MediaWikiServices::getInstance()->getDBLoadBalancer(),
$specialPageName,
$settings->getSetting( 'showExternalRecentChanges' )
);

-- 
To view, visit https://gerrit.wikimedia.org/r/310878
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc77f25a56b7574ebdde1ef927a9346d7996e826
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikidata
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[master]: Avoid deprecated LBFactory::singleton() in tests

2016-09-14 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Avoid deprecated LBFactory::singleton() in tests
..


Avoid deprecated LBFactory::singleton() in tests

Change-Id: Id9c39e9332270f34979db74b251c8f834cce7057
---
M 
extensions/Wikibase/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/extensions/Wikibase/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php
 
b/extensions/Wikibase/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php
index ab0a78d..3abdfaa 100644
--- 
a/extensions/Wikibase/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php
+++ 
b/extensions/Wikibase/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php
@@ -13,6 +13,7 @@
 use Wikibase\Client\RecentChanges\RecentChangeFactory;
 use Wikibase\Client\WikibaseClient;
 use Wikimedia\Assert\Assert;
+use \MediaWiki\MediaWikiServices;
 
 /**
  * @since 0.5
@@ -90,7 +91,7 @@
return new self(
$context->getRequest(),
$context->getUser(),
-   LBFactory::singleton()->getMainLB(),
+   MediaWikiServices::getInstance()->getDBLoadBalancer(),
$specialPageName,
$settings->getSetting( 'showExternalRecentChanges' )
);

-- 
To view, visit https://gerrit.wikimedia.org/r/310728
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id9c39e9332270f34979db74b251c8f834cce7057
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikidata
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: Tobias Gritschacher 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[master]: Avoid deprecated LBFactory::singleton() in tests

2016-09-14 Thread Aaron Schulz (Code Review) 
Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/310728

Change subject: Avoid deprecated LBFactory::singleton() in tests
..

Avoid deprecated LBFactory::singleton() in tests

Change-Id: Id9c39e9332270f34979db74b251c8f834cce7057
---
M 
extensions/Wikibase/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikidata 
refs/changes/28/310728/1

diff --git 
a/extensions/Wikibase/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php
 
b/extensions/Wikibase/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php
index ab0a78d..3abdfaa 100644
--- 
a/extensions/Wikibase/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php
+++ 
b/extensions/Wikibase/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php
@@ -13,6 +13,7 @@
 use Wikibase\Client\RecentChanges\RecentChangeFactory;
 use Wikibase\Client\WikibaseClient;
 use Wikimedia\Assert\Assert;
+use \MediaWiki\MediaWikiServices;
 
 /**
  * @since 0.5
@@ -90,7 +91,7 @@
return new self(
$context->getRequest(),
$context->getUser(),
-   LBFactory::singleton()->getMainLB(),
+   MediaWikiServices::getInstance()->getDBLoadBalancer(),
$specialPageName,
$settings->getSetting( 'showExternalRecentChanges' )
);

-- 
To view, visit https://gerrit.wikimedia.org/r/310728
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9c39e9332270f34979db74b251c8f834cce7057
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikidata
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits