[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: featured-image: better diagnostics in error case

2017-11-16 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/391157 )

Change subject: featured-image: better diagnostics in error case
..


featured-image: better diagnostics in error case

We don't want to have the promise return undefined if an error occurs.
Instead re-throw the error so it doesn't go into the then block.
Hopefully this will provide better diagnostics in the future if the same
thing happens again.

Bug: T180420
Change-Id: I607cf4be08a040de36e45ea531a4f0cb310a95c6
---
M lib/feed/featured-image.js
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Mholloway: Looks good to me, approved



diff --git a/lib/feed/featured-image.js b/lib/feed/featured-image.js
index 3d3b612..ba812dc 100644
--- a/lib/feed/featured-image.js
+++ b/lib/feed/featured-image.js
@@ -204,6 +204,8 @@
 title: 'No picture of the day for this date',
 detail: 'There is no picture of the day for this date.'
 });
+} else {
+throw err;
 }
 });
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/391157
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I607cf4be08a040de36e45ea531a4f0cb310a95c6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Fjalapeno 
Gerrit-Reviewer: Gergő Tisza 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Mhurd 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: featured-image: better diagnostics in error case

2017-11-13 Thread BearND (Code Review) 
BearND has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391157 )

Change subject: featured-image: better diagnostics in error case
..

featured-image: better diagnostics in error case

We don't want to have the promise return undefined if an error occurs.
Instead re-throw the error so it doesn't go into the then block.
Hopefully this will provide better diagnostics in the future if the same
thing happens again.

Bug: T180420
Change-Id: I607cf4be08a040de36e45ea531a4f0cb310a95c6
---
M lib/feed/featured-image.js
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/57/391157/1

diff --git a/lib/feed/featured-image.js b/lib/feed/featured-image.js
index 3d3b612..ba812dc 100644
--- a/lib/feed/featured-image.js
+++ b/lib/feed/featured-image.js
@@ -204,6 +204,8 @@
 title: 'No picture of the day for this date',
 detail: 'There is no picture of the day for this date.'
 });
+} else {
+throw err;
 }
 });
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/391157
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I607cf4be08a040de36e45ea531a4f0cb310a95c6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits