[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Tweak Big English fundraiser copy and start time again

2017-11-29 Thread Mholloway (Code Review) 
Mholloway has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/394205 )

Change subject: Tweak Big English fundraiser copy and start time again
..


Tweak Big English fundraiser copy and start time again

Updated start time and added '.' at end of disclaimer.

Bug: T181004
Change-Id: I9ee81fc634364dcca4ec30cd1a31b27d9527970f
---
M etc/feed/announcements.js
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Mholloway: Verified; Looks good to me, approved



diff --git a/etc/feed/announcements.js b/etc/feed/announcements.js
index 7e1f8d9..dbe1743 100644
--- a/etc/feed/announcements.js
+++ b/etc/feed/announcements.js
@@ -7,7 +7,7 @@
 
 const type = AnnouncementType.FUNDRAISING;
 const activeWiki = 'en.wikipedia.org';
-const startTime = '2017-12-06T16:00:00Z';
+const startTime = '2017-11-30T16:00:00Z';
 const endTime = '2017-12-31T00:00:00Z';
 const idPrefix = 'EN1217';
 const androidDestinationUrl
@@ -18,7 +18,7 @@
 // const imageUrl = undefined; // no image this time
 const buttonLabel = 'Donate now';
 const disclaimerHtml
-= 'By submitting, you are agreeing to our https://wikimediafoundation.org/wiki/Donor_policy/en;>donor privacy 
policy';
+= 'By submitting, you are agreeing to our https://wikimediafoundation.org/wiki/Donor_policy/en;>donor privacy 
policy.';
 
 const countryVariants = [ {
 countryCode: 'US',

-- 
To view, visit https://gerrit.wikimedia.org/r/394205
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9ee81fc634364dcca4ec30cd1a31b27d9527970f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 
Gerrit-Reviewer: Fjalapeno 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Mhurd 
Gerrit-Reviewer: Ppchelko 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Tweak Big English fundraiser copy and start time again

2017-11-29 Thread BearND (Code Review) 
BearND has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394205 )

Change subject: Tweak Big English fundraiser copy and start time again
..

Tweak Big English fundraiser copy and start time again

Updated start time and added '.' at end of disclaimer.

Bug: T181004
Change-Id: I9ee81fc634364dcca4ec30cd1a31b27d9527970f
---
M etc/feed/announcements.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/05/394205/1

diff --git a/etc/feed/announcements.js b/etc/feed/announcements.js
index 7e1f8d9..d761731 100644
--- a/etc/feed/announcements.js
+++ b/etc/feed/announcements.js
@@ -7,7 +7,7 @@
 
 const type = AnnouncementType.FUNDRAISING;
 const activeWiki = 'en.wikipedia.org';
-const startTime = '2017-12-06T16:00:00Z';
+const startTime = '2017-12-01T00:00:00Z';
 const endTime = '2017-12-31T00:00:00Z';
 const idPrefix = 'EN1217';
 const androidDestinationUrl
@@ -18,7 +18,7 @@
 // const imageUrl = undefined; // no image this time
 const buttonLabel = 'Donate now';
 const disclaimerHtml
-= 'By submitting, you are agreeing to our https://wikimediafoundation.org/wiki/Donor_policy/en;>donor privacy 
policy';
+= 'By submitting, you are agreeing to our https://wikimediafoundation.org/wiki/Donor_policy/en;>donor privacy 
policy.';
 
 const countryVariants = [ {
 countryCode: 'US',

-- 
To view, visit https://gerrit.wikimedia.org/r/394205
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ee81fc634364dcca4ec30cd1a31b27d9527970f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Tweak Big English fundraiser copy some more

2017-11-29 Thread Mholloway (Code Review) 
Mholloway has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/394152 )

Change subject: Tweak Big English fundraiser copy some more
..


Tweak Big English fundraiser copy some more

Removed the extra "Privacy disclaimer text: ".

Bug: T181004
Change-Id: Ib15453e03d37988e1d549f5ffdb9062c40737160
---
M etc/feed/announcements.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mholloway: Verified; Looks good to me, approved



diff --git a/etc/feed/announcements.js b/etc/feed/announcements.js
index a02c414..7e1f8d9 100644
--- a/etc/feed/announcements.js
+++ b/etc/feed/announcements.js
@@ -18,7 +18,7 @@
 // const imageUrl = undefined; // no image this time
 const buttonLabel = 'Donate now';
 const disclaimerHtml
-= 'Privacy disclaimer text: By submitting, you are agreeing to our https://wikimediafoundation.org/wiki/Donor_policy/en;>donor privacy 
policy';
+= 'By submitting, you are agreeing to our https://wikimediafoundation.org/wiki/Donor_policy/en;>donor privacy 
policy';
 
 const countryVariants = [ {
 countryCode: 'US',

-- 
To view, visit https://gerrit.wikimedia.org/r/394152
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib15453e03d37988e1d549f5ffdb9062c40737160
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 
Gerrit-Reviewer: Fjalapeno 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Mhurd 
Gerrit-Reviewer: Ppchelko 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Tweak Big English fundraiser copy some more

2017-11-29 Thread BearND (Code Review) 
BearND has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394152 )

Change subject: Tweak Big English fundraiser copy some more
..

Tweak Big English fundraiser copy some more

Removed the extra "Privacy disclaimer text: ".

Bug: T181004
Change-Id: Ib15453e03d37988e1d549f5ffdb9062c40737160
---
M etc/feed/announcements.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/52/394152/1

diff --git a/etc/feed/announcements.js b/etc/feed/announcements.js
index a02c414..7e1f8d9 100644
--- a/etc/feed/announcements.js
+++ b/etc/feed/announcements.js
@@ -18,7 +18,7 @@
 // const imageUrl = undefined; // no image this time
 const buttonLabel = 'Donate now';
 const disclaimerHtml
-= 'Privacy disclaimer text: By submitting, you are agreeing to our https://wikimediafoundation.org/wiki/Donor_policy/en;>donor privacy 
policy';
+= 'By submitting, you are agreeing to our https://wikimediafoundation.org/wiki/Donor_policy/en;>donor privacy 
policy';
 
 const countryVariants = [ {
 countryCode: 'US',

-- 
To view, visit https://gerrit.wikimedia.org/r/394152
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib15453e03d37988e1d549f5ffdb9062c40737160
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Tweak Big English fundraiser copy and start time

2017-11-29 Thread Mholloway (Code Review) 
Mholloway has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/394107 )

Change subject: Tweak Big English fundraiser copy and start time
..


Tweak Big English fundraiser copy and start time

Now with double the line breaks and updated button label.
Postponed the start time to Wednesday, 12/06
since I have not heard about the final approval of things yet.

Bug: T181004
Change-Id: Icc8485f603b8c1aae2b3af4d0e58a1b9e6c23854
---
M etc/feed/announcements.js
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Mholloway: Verified; Looks good to me, approved



diff --git a/etc/feed/announcements.js b/etc/feed/announcements.js
index 4af8fde..a02c414 100644
--- a/etc/feed/announcements.js
+++ b/etc/feed/announcements.js
@@ -7,7 +7,7 @@
 
 const type = AnnouncementType.FUNDRAISING;
 const activeWiki = 'en.wikipedia.org';
-const startTime = '2017-11-30T16:00:00Z';
+const startTime = '2017-12-06T16:00:00Z';
 const endTime = '2017-12-31T00:00:00Z';
 const idPrefix = 'EN1217';
 const androidDestinationUrl
@@ -16,7 +16,7 @@
 = 
'https://donate.wikimedia.org/?uselang=en_medium=WikipediaAppFeed_campaign=iOS_source=app_201712_6C_control';
 // TODO: consider removing jshint
 // const imageUrl = undefined; // no image this time
-const buttonLabel = 'Donate today';
+const buttonLabel = 'Donate now';
 const disclaimerHtml
 = 'Privacy disclaimer text: By submitting, you are agreeing to our https://wikimediafoundation.org/wiki/Donor_policy/en;>donor privacy 
policy';
 
@@ -66,7 +66,9 @@
 // replaced %COUNTRY% with ${country}, ...
 /* eslint-disable max-len */
 return `Hi reader in ${country}, it seems you use Wikipedia a lot; I think 
that’s great and hope you find it useful.
+
 It’s a little awkward to ask, but today we need your help. We depend on 
donations averaging ${currency}${average}, but fewer than 1% of readers choose 
to give. If you donate just ${currency}${coffee}, you would help keep Wikipedia 
thriving for years. That’s right, the price of a cup of coffee is all I ask. 
Please take a minute to keep Wikipedia growing.
+
 Thank you. — Jimmy Wales, Wikipedia Founder`;
 /* eslint-enable max-len */
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/394107
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icc8485f603b8c1aae2b3af4d0e58a1b9e6c23854
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Fjalapeno 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Mhurd 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Tweak Big English fundraiser copy

2017-11-29 Thread BearND (Code Review) 
BearND has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394107 )

Change subject: Tweak Big English fundraiser copy
..

Tweak Big English fundraiser copy

Now with double the line breaks and updated button label.

Bug: T181004
Change-Id: Icc8485f603b8c1aae2b3af4d0e58a1b9e6c23854
---
M etc/feed/announcements.js
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/07/394107/1

diff --git a/etc/feed/announcements.js b/etc/feed/announcements.js
index 4af8fde..e4e2f4d 100644
--- a/etc/feed/announcements.js
+++ b/etc/feed/announcements.js
@@ -16,7 +16,7 @@
 = 
'https://donate.wikimedia.org/?uselang=en_medium=WikipediaAppFeed_campaign=iOS_source=app_201712_6C_control';
 // TODO: consider removing jshint
 // const imageUrl = undefined; // no image this time
-const buttonLabel = 'Donate today';
+const buttonLabel = 'Donate now';
 const disclaimerHtml
 = 'Privacy disclaimer text: By submitting, you are agreeing to our https://wikimediafoundation.org/wiki/Donor_policy/en;>donor privacy 
policy';
 
@@ -66,7 +66,9 @@
 // replaced %COUNTRY% with ${country}, ...
 /* eslint-disable max-len */
 return `Hi reader in ${country}, it seems you use Wikipedia a lot; I think 
that’s great and hope you find it useful.
+
 It’s a little awkward to ask, but today we need your help. We depend on 
donations averaging ${currency}${average}, but fewer than 1% of readers choose 
to give. If you donate just ${currency}${coffee}, you would help keep Wikipedia 
thriving for years. That’s right, the price of a cup of coffee is all I ask. 
Please take a minute to keep Wikipedia growing.
+
 Thank you. — Jimmy Wales, Wikipedia Founder`;
 /* eslint-enable max-len */
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/394107
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc8485f603b8c1aae2b3af4d0e58a1b9e6c23854
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits