[MediaWiki-commits] [Gerrit] oojs/ui[master]: ComboBoxInputWidget: Hide dropdown indicator when there is n...

2016-09-15 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: ComboBoxInputWidget: Hide dropdown indicator when there is no 
dropdown
..


ComboBoxInputWidget: Hide dropdown indicator when there is no dropdown

Hiding dropdown indicator when class `.oo-ui-comboBoxInputWidget-empty`
is set.

Bug: T145714
Change-Id: I0b087bc56e19e1d0be63d145b00426b8aee2efc5
---
M src/styles/widgets/ComboBoxInputWidget.less
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  Prtksxna: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/src/styles/widgets/ComboBoxInputWidget.less 
b/src/styles/widgets/ComboBoxInputWidget.less
index 4a6babe..1d1789b 100644
--- a/src/styles/widgets/ComboBoxInputWidget.less
+++ b/src/styles/widgets/ComboBoxInputWidget.less
@@ -3,6 +3,12 @@
 .oo-ui-comboBoxInputWidget {
display: inline-block;
 
+   &.oo-ui-comboBoxInputWidget-empty {
+   > .oo-ui-indicatorElement-indicator {
+   display: none;
+   }
+   }
+
&.oo-ui-widget-enabled {
> .oo-ui-indicatorElement-indicator {
cursor: pointer;

-- 
To view, visit https://gerrit.wikimedia.org/r/310716
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0b087bc56e19e1d0be63d145b00426b8aee2efc5
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Prtksxna 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: ComboBoxInputWidget: Hide dropdown indicator when there is n...

2016-09-14 Thread VolkerE (Code Review) 
VolkerE has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/310716

Change subject: ComboBoxInputWidget: Hide dropdown indicator when there is no 
dropdown
..

ComboBoxInputWidget: Hide dropdown indicator when there is no dropdown

Hiding dropdown indicator when class `.oo-ui-comboBoxInputWidget-empty`
is set.

Bug: T145176
Change-Id: I0b087bc56e19e1d0be63d145b00426b8aee2efc5
---
M src/styles/widgets/ComboBoxInputWidget.less
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/16/310716/1

diff --git a/src/styles/widgets/ComboBoxInputWidget.less 
b/src/styles/widgets/ComboBoxInputWidget.less
index 4a6babe..1d1789b 100644
--- a/src/styles/widgets/ComboBoxInputWidget.less
+++ b/src/styles/widgets/ComboBoxInputWidget.less
@@ -3,6 +3,12 @@
 .oo-ui-comboBoxInputWidget {
display: inline-block;
 
+   &.oo-ui-comboBoxInputWidget-empty {
+   > .oo-ui-indicatorElement-indicator {
+   display: none;
+   }
+   }
+
&.oo-ui-widget-enabled {
> .oo-ui-indicatorElement-indicator {
cursor: pointer;

-- 
To view, visit https://gerrit.wikimedia.org/r/310716
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b087bc56e19e1d0be63d145b00426b8aee2efc5
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits