jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/371472 )
Change subject: update mediawiki-codesniffer to 0.11.0 and fix issues
......................................................................
update mediawiki-codesniffer to 0.11.0 and fix issues
It seems, that the bool auto fixes also mess with
line breakes in comments in some cases.
- fixes by auto checks
- long line fixes
Change-Id: Id25d518ff733f5d6db58cedbb4d88a64684919ae
---
M composer.json
M php/Tag.php
M php/Widget.php
M php/layouts/PanelLayout.php
M php/mixins/ButtonElement.php
M php/widgets/ButtonInputWidget.php
M php/widgets/ButtonWidget.php
M php/widgets/CheckboxInputWidget.php
M php/widgets/ProgressBarWidget.php
M php/widgets/RadioInputWidget.php
M php/widgets/TextInputWidget.php
11 files changed, 29 insertions(+), 29 deletions(-)
Approvals:
jenkins-bot: Verified
VolkerE: Looks good to me, approved
diff --git a/composer.json b/composer.json
index 0270fe6..a2df46e 100644
--- a/composer.json
+++ b/composer.json
@@ -51,7 +51,7 @@
],
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "mediawiki/mediawiki-codesniffer": "0.10.1",
+ "mediawiki/mediawiki-codesniffer": "0.11.0",
"phpunit/phpunit": "4.8.21"
},
"autoload": {
diff --git a/php/Tag.php b/php/Tag.php
index 44d35a8..1c308bd 100644
--- a/php/Tag.php
+++ b/php/Tag.php
@@ -95,7 +95,7 @@
* Toggle CSS classes.
*
* @param array $classes List of classes to add
- * @param boolean $toggle Add classes
+ * @param bool $toggle Add classes
* @return $this
*/
public function toggleClasses( array $classes, $toggle = null ) {
@@ -253,7 +253,7 @@
/**
* Enable widget for client-side infusion.
*
- * @param boolean $infusable True to allow tag/element/widget to be
referenced client-side.
+ * @param bool $infusable True to allow tag/element/widget to be
referenced client-side.
* @return $this
*/
public function setInfusable( $infusable ) {
diff --git a/php/Widget.php b/php/Widget.php
index 2f4573f..1936414 100644
--- a/php/Widget.php
+++ b/php/Widget.php
@@ -22,7 +22,7 @@
/**
* @param array $config Configuration options
- * @param boolean $config['disabled'] Disable (default: false)
+ * @param bool $config['disabled'] Disable (default: false)
*/
public function __construct( array $config = [] ) {
// Initialize config
@@ -50,7 +50,7 @@
*
* This should probably change the widgets' appearance and prevent it
from being used.
*
- * @param boolean $disabled Disable widget
+ * @param bool $disabled Disable widget
* @return $this
*/
public function setDisabled( $disabled ) {
diff --git a/php/layouts/PanelLayout.php b/php/layouts/PanelLayout.php
index 00a4cb5..83ad87c 100644
--- a/php/layouts/PanelLayout.php
+++ b/php/layouts/PanelLayout.php
@@ -8,11 +8,11 @@
class PanelLayout extends Layout {
/**
* @param array $config Configuration options
- * @param boolean $config['scrollable'] Allow vertical scrolling
(default: false)
- * @param boolean $config['padded'] Pad the content from the edges
(default: false)
- * @param boolean $config['expanded'] Expand size to fill the entire
parent element
+ * @param bool $config['scrollable'] Allow vertical scrolling (default:
false)
+ * @param bool $config['padded'] Pad the content from the edges
(default: false)
+ * @param bool $config['expanded'] Expand size to fill the entire
parent element
* (default: true)
- * @param boolean $config['framed'] Wrap in a frame to visually
separate from outside content
+ * @param bool $config['framed'] Wrap in a frame to visually separate
from outside content
* (default: false)
*/
public function __construct( array $config = [] ) {
diff --git a/php/mixins/ButtonElement.php b/php/mixins/ButtonElement.php
index c91a158..eaf0651 100644
--- a/php/mixins/ButtonElement.php
+++ b/php/mixins/ButtonElement.php
@@ -26,7 +26,7 @@
/**
* @param array $config Configuration options
- * @param boolean $config['framed'] Render button with a frame
(default: true)
+ * @param bool $config['framed'] Render button with a frame (default:
true)
*/
public function initializeButtonElement( array $config = [] ) {
// Properties
@@ -58,7 +58,7 @@
/**
* Toggle frame.
*
- * @param boolean $framed Make button framed, omit to toggle
+ * @param bool $framed Make button framed, omit to toggle
* @return $this
*/
public function toggleFramed( $framed = null ) {
diff --git a/php/widgets/ButtonInputWidget.php
b/php/widgets/ButtonInputWidget.php
index da96dc7..b356f7c 100644
--- a/php/widgets/ButtonInputWidget.php
+++ b/php/widgets/ButtonInputWidget.php
@@ -30,7 +30,7 @@
* @param array $config Configuration options
* @param string $config['type'] HTML tag `type` attribute, may be
'button', 'submit' or 'reset'
* (default: 'button')
- * @param boolean $config['useInputTag'] Whether to use `<input>`
rather than `<button>`. Only
+ * @param bool $config['useInputTag'] Whether to use `<input>` rather
than `<button>`. Only
* useful if you need IE 6 support in a form with multiple buttons.
If you use this option,
* icons and indicators will not be displayed, it won't be possible
to have a non-plaintext
* label, and it won't be possible to set a value (which will
internally become identical to the
diff --git a/php/widgets/ButtonWidget.php b/php/widgets/ButtonWidget.php
index 43f1d99..1312ca9 100644
--- a/php/widgets/ButtonWidget.php
+++ b/php/widgets/ButtonWidget.php
@@ -53,10 +53,10 @@
/**
* @param array $config Configuration options
- * @param boolean $config['active'] Whether button should be shown as
active (default: false)
+ * @param bool $config['active'] Whether button should be shown as
active (default: false)
* @param string $config['href'] Hyperlink to visit when clicked
* @param string $config['target'] Target to open hyperlink in
- * @param boolean $config['noFollow'] Search engine traversal hint
(default: true)
+ * @param bool $config['noFollow'] Search engine traversal hint
(default: true)
*/
public function __construct( array $config = [] ) {
// Parent constructor
@@ -164,7 +164,7 @@
/**
* Set search engine traversal hint.
*
- * @param boolean $noFollow True if search engines should avoid
traversing this hyperlink
+ * @param bool $noFollow True if search engines should avoid traversing
this hyperlink
* @return $this
*/
public function setNoFollow( $noFollow ) {
@@ -184,7 +184,7 @@
*
* A button should be marked as active when clicking it would only
refresh the page.
*
- * @param boolean $active Make button active
+ * @param bool $active Make button active
* @return $this
*/
public function setActive( $active = null ) {
diff --git a/php/widgets/CheckboxInputWidget.php
b/php/widgets/CheckboxInputWidget.php
index 458c73e..3b69497 100644
--- a/php/widgets/CheckboxInputWidget.php
+++ b/php/widgets/CheckboxInputWidget.php
@@ -22,7 +22,7 @@
/**
* @param array $config Configuration options
- * @param boolean $config['selected'] Whether the checkbox is initially
selected
+ * @param bool $config['selected'] Whether the checkbox is initially
selected
* (default: false)
*/
public function __construct( array $config = [] ) {
@@ -43,7 +43,7 @@
/**
* Set selection state of this checkbox.
*
- * @param boolean $state Whether the checkbox is selected
+ * @param bool $state Whether the checkbox is selected
* @return $this
*/
public function setSelected( $state ) {
diff --git a/php/widgets/ProgressBarWidget.php
b/php/widgets/ProgressBarWidget.php
index e49ea20..e7906c8 100644
--- a/php/widgets/ProgressBarWidget.php
+++ b/php/widgets/ProgressBarWidget.php
@@ -15,7 +15,7 @@
/**
* @param array $config Configuration options
- * @param bool|int $config['progress'] Numeric value between 0 and 100
(the percent complete)
+ * @param boolean|int $config['progress'] Numeric value between 0 and
100 (the percent complete)
* for determinate progress bar, or `false` for indeterminate
progress bar (default: false)
*/
public function __construct( array $config = [] ) {
@@ -44,7 +44,7 @@
}
/**
- * @param bool|int $progress Numeric value between 0 and 100 (the
percent complete)
+ * @param boolean|int $progress Numeric value between 0 and 100 (the
percent complete)
* for determinate progress bar, or `false` for indeterminate
progress bar (default: false)
*/
public function setProgress( $progress ) {
diff --git a/php/widgets/RadioInputWidget.php b/php/widgets/RadioInputWidget.php
index 15a36a6..5f96a01 100644
--- a/php/widgets/RadioInputWidget.php
+++ b/php/widgets/RadioInputWidget.php
@@ -13,7 +13,7 @@
/**
* @param array $config Configuration options
- * @param boolean $config['selected'] Whether the radio button is
initially selected
+ * @param bool $config['selected'] Whether the radio button is
initially selected
* (default: false)
*/
public function __construct( array $config = [] ) {
@@ -34,7 +34,7 @@
/**
* Set selection state of this radio button.
*
- * @param boolean $state Whether the button is selected
+ * @param bool $state Whether the button is selected
* @return $this
*/
public function setSelected( $state ) {
diff --git a/php/widgets/TextInputWidget.php b/php/widgets/TextInputWidget.php
index 30afcce..37ed3e1 100644
--- a/php/widgets/TextInputWidget.php
+++ b/php/widgets/TextInputWidget.php
@@ -48,15 +48,15 @@
* - `search`: implies `icon: 'search'` and `indicator: 'clear'`;
when clicked, the indicator
* empties the text field
* @param string $config['placeholder'] Placeholder text
- * @param boolean $config['autofocus'] Ask the browser to focus this
widget, using the 'autofocus'
+ * @param bool $config['autofocus'] Ask the browser to focus this
widget, using the 'autofocus'
* HTML attribute (default: false)
- * @param boolean $config['readOnly'] Prevent changes (default: false)
+ * @param bool $config['readOnly'] Prevent changes (default: false)
* @param number $config['maxLength'] Maximum allowed number of
characters to input
- * @param boolean $config['multiline'] Allow multiple lines of text
(default: false)
+ * @param bool $config['multiline'] Allow multiple lines of text
(default: false)
* @param int $config['rows'] If multiline, number of visible lines in
textarea
- * @param boolean $config['required'] Mark the field as required.
+ * @param bool $config['required'] Mark the field as required.
* Implies `indicator: 'required'`. (default: false)
- * @param boolean $config['autocomplete'] If the field should support
autocomplete
+ * @param bool $config['autocomplete'] If the field should support
autocomplete
* or not (default: true)
*/
public function __construct( array $config = [] ) {
@@ -125,7 +125,7 @@
* Set the read-only state of the widget. This should probably change
the widget's appearance and
* prevent it from being used.
*
- * @param boolean $state Make input read-only
+ * @param bool $state Make input read-only
* @return $this
*/
public function setReadOnly( $state ) {
@@ -150,7 +150,7 @@
/**
* Set the required state of the widget.
*
- * @param boolean $state Make input required
+ * @param bool $state Make input required
* @return $this
*/
public function setRequired( $state ) {
--
To view, visit https://gerrit.wikimedia.org/r/371472
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id25d518ff733f5d6db58cedbb4d88a64684919ae
Gerrit-PatchSet: 7
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: WMDE-Fisch <christoph.jau...@wikimedia.de>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: WMDE-Fisch <christoph.jau...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
