[MediaWiki-commits] [Gerrit] operations/puppet[production]: htcppurger: quoting bugfix for host_regex

2016-09-18 Thread BBlack (Code Review)
BBlack has submitted this change and it was merged.

Change subject: htcppurger: quoting bugfix for host_regex
..


htcppurger: quoting bugfix for host_regex

Even with a simple string, apparently it's still possible to get
quoting wrong through the various layers :)

Change-Id: I537ebc0e25224c37a683fdc11ab7aa52511665e2
---
M modules/varnish/manifests/htcppurger.pp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  BBlack: Verified; Looks good to me, approved



diff --git a/modules/varnish/manifests/htcppurger.pp 
b/modules/varnish/manifests/htcppurger.pp
index a92fa51..7f647c5 100644
--- a/modules/varnish/manifests/htcppurger.pp
+++ b/modules/varnish/manifests/htcppurger.pp
@@ -41,7 +41,7 @@
 }
 
 if $host_regex != '' {
-$regex_arg = " -r '${host_regex}'"
+$regex_arg = " -r ${host_regex}"
 }
 else {
 $regex_arg = ''

-- 
To view, visit https://gerrit.wikimedia.org/r/311333
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I537ebc0e25224c37a683fdc11ab7aa52511665e2
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack 
Gerrit-Reviewer: BBlack 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] operations/puppet[production]: htcppurger: quoting bugfix for host_regex

2016-09-18 Thread BBlack (Code Review)
BBlack has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311333

Change subject: htcppurger: quoting bugfix for host_regex
..

htcppurger: quoting bugfix for host_regex

Even with a simple string, apparently it's still possible to get
quoting wrong through the various layers :)

Change-Id: I537ebc0e25224c37a683fdc11ab7aa52511665e2
---
M modules/varnish/manifests/htcppurger.pp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/33/311333/1

diff --git a/modules/varnish/manifests/htcppurger.pp 
b/modules/varnish/manifests/htcppurger.pp
index a92fa51..7f647c5 100644
--- a/modules/varnish/manifests/htcppurger.pp
+++ b/modules/varnish/manifests/htcppurger.pp
@@ -41,7 +41,7 @@
 }
 
 if $host_regex != '' {
-$regex_arg = " -r '${host_regex}'"
+$regex_arg = " -r ${host_regex}"
 }
 else {
 $regex_arg = ''

-- 
To view, visit https://gerrit.wikimedia.org/r/311333
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I537ebc0e25224c37a683fdc11ab7aa52511665e2
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits