Dzahn has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/379422 )
Change subject: phab/aphlict: remove require for group by user
......................................................................
phab/aphlict: remove require for group by user
follow-up to Change-Id I582deafa4faea0f45 which introduced
a puppet error when it tries to create the user "aphlict" due
to missing group "aphlict" even though it should be created and
there is a "require" for it.
Following examples in puppet docs, there is no require needed
between group and user like that.
Bug: T765
Change-Id: Ia9b72f9caf26fb5cc2a0971f0673d283b2de31ee
---
M modules/phabricator/manifests/aphlict.pp
1 file changed, 4 insertions(+), 5 deletions(-)
Approvals:
jenkins-bot: Verified
Dzahn: Looks good to me, approved
diff --git a/modules/phabricator/manifests/aphlict.pp
b/modules/phabricator/manifests/aphlict.pp
index e76b9f0..6db523f 100644
--- a/modules/phabricator/manifests/aphlict.pp
+++ b/modules/phabricator/manifests/aphlict.pp
@@ -73,11 +73,10 @@
}
user { $user:
- gid => $group,
- shell => '/bin/false',
- home => '/var/run/aphlict',
- system => true,
- require => Group[$group],
+ gid => $group,
+ shell => '/bin/false',
+ home => '/var/run/aphlict',
+ system => true,
}
base::service_unit { 'aphlict':
--
To view, visit https://gerrit.wikimedia.org/r/379422
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9b72f9caf26fb5cc2a0971f0673d283b2de31ee
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <dz...@wikimedia.org>
Gerrit-Reviewer: Dzahn <dz...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
