Dzahn has submitted this change and it was merged.
Change subject: Gerrit: Fix phabricator expanding links
......................................................................
Gerrit: Fix phabricator expanding links
@Author of change Thiemo Mättig (WMDE)
Bug: T75997
Change-Id: Icf71cdb7722293de95419e7e191efbc7684ff1af
---
M modules/gerrit/templates/gerrit.config.erb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Paladox: Looks good to me, but someone else must approve
Thiemo Mättig (WMDE): Looks good to me, but someone else must approve
jenkins-bot: Verified
Dzahn: Looks good to me, approved
Objections:
Peachey88: There's a problem with this change, please improve
diff --git a/modules/gerrit/templates/gerrit.config.erb
b/modules/gerrit/templates/gerrit.config.erb
index 0459ebc..57330b5 100644
--- a/modules/gerrit/templates/gerrit.config.erb
+++ b/modules/gerrit/templates/gerrit.config.erb
@@ -123,7 +123,7 @@
# that we use, $1 needs to hold the bug number. By the way the
# pattern gets used, neither non-capturing groups nor
# look-aheads/look-backs work reliably.
- match = "\\bT(\\d+)(#\\d+)?\\b(?!\")"
+ match = "\\bT(\\d+)(#\\d+)?\\b(?![#\"]|</a>)"
link = https://phabricator.wikimedia.org/T$1$2
[mimetype "application/javascript"]
safe = true
--
To view, visit https://gerrit.wikimedia.org/r/306413
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf71cdb7722293de95419e7e191efbc7684ff1af
Gerrit-PatchSet: 13
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Paladox <thomasmulhall...@yahoo.com>
Gerrit-Reviewer: 20after4 <mmod...@wikimedia.org>
Gerrit-Reviewer: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Dzahn <dz...@wikimedia.org>
Gerrit-Reviewer: Paladox <thomasmulhall...@yahoo.com>
Gerrit-Reviewer: Peachey88 <p858sn...@gmail.com>
Gerrit-Reviewer: QChris <christ...@quelltextlich.at>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
