[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Remove ldap user and password from secure.config

2017-11-14 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366910 )

Change subject: Gerrit: Remove ldap user and password from secure.config
..


Gerrit: Remove ldap user and password from secure.config

It's not really needed now or is it?

We can connect anonymous to ldap so we doin't need a user or password.

Change-Id: Ie1df3bfc706129ba5d7f4ec82d08cde1e228e3fe
---
M modules/gerrit/templates/secure.config.erb
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Chad: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/modules/gerrit/templates/secure.config.erb 
b/modules/gerrit/templates/secure.config.erb
index eea1f0d..f1a0a57 100644
--- a/modules/gerrit/templates/secure.config.erb
+++ b/modules/gerrit/templates/secure.config.erb
@@ -1,8 +1,5 @@
 [database]
password = <%= @db_pass %>
-[ldap]
-   username = <%= @ldap_proxyagent %>
-   password = <%= @ldap_proxyagent_pass %>
 [auth]
registerEmailPrivateKey = <%= @email_key %>
 [its-phabricator]

-- 
To view, visit https://gerrit.wikimedia.org/r/366910
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1df3bfc706129ba5d7f4ec82d08cde1e228e3fe
Gerrit-PatchSet: 17
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Paladox 
Gerrit-Reviewer: BryanDavis 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Muehlenhoff 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Remove ldap user and password from secure.config

2017-07-21 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366910 )

Change subject: Gerrit: Remove ldap user and password from secure.config
..

Gerrit: Remove ldap user and password from secure.config

It's not really needed now or is it?

We can connect annon to ldap we doing need a user or password.

Change-Id: Ie1df3bfc706129ba5d7f4ec82d08cde1e228e3fe
---
0 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/10/366910/1


-- 
To view, visit https://gerrit.wikimedia.org/r/366910
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1df3bfc706129ba5d7f4ec82d08cde1e228e3fe
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Paladox 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits