Filippo Giunchedi has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/401707 )

Change subject: smart: pin smartmontools to backports on Debian
......................................................................


smart: pin smartmontools to backports on Debian

We are not enabling backports on (deprecated) Trusty.

Bug: T86552
Change-Id: I4510bd0d538502d158833560bb2e375cba23a9b2
---
M modules/smart/manifests/init.pp
1 file changed, 11 insertions(+), 4 deletions(-)

Approvals:
  jenkins-bot: Verified
  Filippo Giunchedi: Looks good to me, approved



diff --git a/modules/smart/manifests/init.pp b/modules/smart/manifests/init.pp
index 90d9dab..0e70724 100644
--- a/modules/smart/manifests/init.pp
+++ b/modules/smart/manifests/init.pp
@@ -9,11 +9,18 @@
         fail('smart module is not supported on virtual hosts')
     }
 
-    # Prefer smartmontools version from backports (if any) because of newer
-    # smart drivedb.
+    # Prefer smartmontools version from backports (on Debian, if any) because 
of newer smart
+    # drivedb.
+    if os_version('debian >= jessie') {
+        apt::pin { 'smartmontools_backports':
+            pin      => "release a=${::lsbdistcodename}-backports",
+            priority => '1001',
+            before   => Package['smartmontools'],
+        }
+    }
+
     package { 'smartmontools':
-        ensure          => $ensure,
-        install_options => ['-t', "${::lsbdistcodename}-backports"],
+        ensure => $ensure,
     }
 
     # Make sure we send smart alerts from smartd via syslog and not email.

-- 
To view, visit https://gerrit.wikimedia.org/r/401707
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4510bd0d538502d158833560bb2e375cba23a9b2
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: Jcrespo <jcre...@wikimedia.org>
Gerrit-Reviewer: Muehlenhoff <mmuhlenh...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to