Filippo Giunchedi has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/401707 )

Change subject: smart: special case for backports on Ubuntu
......................................................................

smart: special case for backports on Ubuntu

We don't ship trusty-backports, thus special case the install on Ubuntu.

Bug: T86552
Change-Id: I4510bd0d538502d158833560bb2e375cba23a9b2
---
M modules/smart/manifests/init.pp
1 file changed, 10 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/07/401707/1

diff --git a/modules/smart/manifests/init.pp b/modules/smart/manifests/init.pp
index 90d9dab..7129480 100644
--- a/modules/smart/manifests/init.pp
+++ b/modules/smart/manifests/init.pp
@@ -9,11 +9,17 @@
         fail('smart module is not supported on virtual hosts')
     }
 
-    # Prefer smartmontools version from backports (if any) because of newer
+    # Prefer smartmontools version from backports (on Debian, if any) because 
of newer
     # smart drivedb.
-    package { 'smartmontools':
-        ensure          => $ensure,
-        install_options => ['-t', "${::lsbdistcodename}-backports"],
+    if os_version('ubuntu >= trusty') {
+        package { 'smartmontools':
+            ensure => $ensure,
+        }
+    } else {
+        package { 'smartmontools':
+            ensure          => $ensure,
+            install_options => ['-t', "${::lsbdistcodename}-backports"],
+        }
     }
 
     # Make sure we send smart alerts from smartd via syslog and not email.

-- 
To view, visit https://gerrit.wikimedia.org/r/401707
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4510bd0d538502d158833560bb2e375cba23a9b2
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to