Xqt has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404435 )
Change subject: [compat2core] Note different results of getVersionHistory ...................................................................... [compat2core] Note different results of getVersionHistory - Page.getVersionHistory() gives a list of tuples with 4 items but tuple has 6 items in compat. Notify it in compat2core.py This is an alternate implementation to solve T136513. See: https://gerrit.wikimedia.org/r/#/c/291605/7 Bug: T136513 Change-Id: Ibd89306199ee346369d9241a78f61b94fcc3b9f3 --- M pywikibot/page.py M scripts/maintenance/compat2core.py 2 files changed, 10 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core refs/changes/35/404435/1 diff --git a/pywikibot/page.py b/pywikibot/page.py index 767835d..fb6acd2 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -1699,9 +1699,13 @@ return (self._revisions[rev] for rev in sorted(self._revisions, reverse=not reverse)[:total]) - # BREAKING CHANGE: in old framework, default value for getVersionHistory - # returned no more than 500 revisions; now, it iterates - # all revisions unless 'total' argument is used + # BREAKING CHANGES: + # - in old framework, default value for getVersionHistory returned nomore + # than 500 revisions; now, it iterates all revisions unless 'total' + # argument is used + # - timestamp is a pywikibot.Timestampe, not a MediaWiki timestamp string + # - old framework return a tuple of 6 items but size and tags are missing + # here @deprecated('Page.revisions()') @deprecated_args(forceReload=None, revCount='total', step=None, getAll=None, reverseOrder='reverse') diff --git a/scripts/maintenance/compat2core.py b/scripts/maintenance/compat2core.py index 4e62b64..827bed5 100755 --- a/scripts/maintenance/compat2core.py +++ b/scripts/maintenance/compat2core.py @@ -99,8 +99,9 @@ ('.replaceImage(', 'Page.replaceImage() is deprecated and does not work at core'), ('.getVersionHistory(', - 'Page.getVersionHistory() returns a pywikibot.Timestamp object instead of\n' - 'a MediaWiki one'), + 'Page.getVersionHistory() returns a pywikibot.Timestamp object instead\n' + 'of a MediaWiki one. It also returns a tuple of 4 items instead of 6:\n' + 'size and tags items are missing. Use Page.revisions instead.'), ('.contributions(', 'User.contributions() returns a pywikibot.Timestamp object instead of a\n' 'MediaWiki one'), -- To view, visit https://gerrit.wikimedia.org/r/404435 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibd89306199ee346369d9241a78f61b94fcc3b9f3 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <i...@gno.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
